Skip to content

Submit/fvwm module#1532

Closed
sprock wants to merge 7 commits intoNixOS:masterfrom
sprock:submit/fvwm-module
Closed

Submit/fvwm module#1532
sprock wants to merge 7 commits intoNixOS:masterfrom
sprock:submit/fvwm-module

Conversation

@sprock
Copy link
Contributor

@sprock sprock commented Jan 15, 2014

New module for fvwm window manager.

@bjornfor
Copy link
Contributor

Hi. It seems each of your pulls are a superset of the previous. It would be much better if you base each pull on the upstream master branch instead of basing it on the branch you just submitted a pull from.

@bjornfor
Copy link
Contributor

You can fix it with git rebase -i origin/master and git push --force.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you chose license from stdenv.lib.licenses. please

This was referenced Jan 16, 2014
@domenkozar
Copy link
Member

@sprock could you update this PR to only include relevant changes?

@domenkozar
Copy link
Member

@sprock ping, do you need help with cleaning this up?

@bjornfor
Copy link
Contributor

I think the only thing remaining in this pull (not already merged manually) is the pmount url (and hash?) update and the addition of the fvwm module.

I did a cleanup of the fvwm module some time ago, but I never pushed it. It's here: bjornfor@b123383

@domenkozar
Copy link
Member

@bjornfor cool, I'll leave it to you then :-)

@bjornfor
Copy link
Contributor

bjornfor commented Mar 7, 2014

@sprock: still interested in the fvwm module?

@shlevy
Copy link
Member

shlevy commented Mar 14, 2014

@sprock If you're still interested in finishing this work up, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants