Skip to content

python3Packages.dm-haiku: init at 0.0.5#153122

Merged
samuela merged 1 commit intoNixOS:masterfrom
ndl:submit/dm-haiku
Jan 5, 2022
Merged

python3Packages.dm-haiku: init at 0.0.5#153122
samuela merged 1 commit intoNixOS:masterfrom
ndl:submit/dm-haiku

Conversation

@ndl
Copy link
Contributor

@ndl ndl commented Jan 1, 2022

Motivation for this change

Part of "extra JAX libraries / frameworks" implementation, see the discussion in #152754

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ndl ndl requested review from FRidh and jonringer as code owners January 1, 2022 23:28
@ndl ndl requested a review from samuela January 1, 2022 23:29
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 1, 2022
Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'll squash and merge in a day or two unless someone objects

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 2, 2022
@ndl
Copy link
Contributor Author

ndl commented Jan 5, 2022

@samuela do you mind merging this PR if there are no concerns with it? I need it for the rest of optax -> flax -> treex -> elegy dependency chain. Thanks!

@samuela samuela merged commit 8ef375f into NixOS:master Jan 5, 2022
@samuela
Copy link
Member

samuela commented Jan 5, 2022

@ndl Done! sorry I forgot to come back and merge this one, thanks for pinging me!

@ndl
Copy link
Contributor Author

ndl commented Jan 5, 2022

@samuela NP, thank you! Proceeding with the remaining packages :-)

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 153122 run on x86_64-linux 1

2 packages built:
  • python38Packages.dm-haiku
  • python39Packages.dm-haiku

@jonringer
Copy link
Contributor

oh, looks like im late :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants