Skip to content

pipewire: introduce roc-toolkit support#153087

Merged
Mic92 merged 4 commits intoNixOS:masterfrom
bgamari:wip/roc-toolkit
Jan 4, 2022
Merged

pipewire: introduce roc-toolkit support#153087
Mic92 merged 4 commits intoNixOS:masterfrom
bgamari:wip/roc-toolkit

Conversation

@bgamari
Copy link
Contributor

@bgamari bgamari commented Jan 1, 2022

Motivation for this change

roc-streaming is a library for robust streaming of audio data over (unreliable) networks. pipewire has support for it via the libpipewire-module-roc-{sink,source} modules. Here I add derivations for the openfec and roc-toolkit libraries, as well as introduce support for the latter in the pipewire derivation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bgamari
Copy link
Contributor Author

bgamari commented Jan 1, 2022

Ccing @jansol

N.B. I have based this on #150999

@bgamari bgamari force-pushed the wip/roc-toolkit branch 3 times, most recently from a44cc19 to 6461cf9 Compare January 1, 2022 17:33
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 1, 2022
@ofborg ofborg bot requested review from Kranzes and jtojnar January 1, 2022 17:45
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 1, 2022
@bgamari bgamari force-pushed the wip/roc-toolkit branch 2 times, most recently from 66e2c88 to b627f5d Compare January 1, 2022 17:56
@bgamari bgamari force-pushed the wip/roc-toolkit branch 2 times, most recently from 30b0dc3 to 7cfae9a Compare January 1, 2022 22:34
@bgamari bgamari mentioned this pull request Jan 1, 2022
12 tasks
This allows the `libpipewire-module-roc-{source,sink}` modules to be
built.
@Mic92
Copy link
Member

Mic92 commented Jan 2, 2022

@jansol all good?

@jansol
Copy link
Contributor

jansol commented Jan 2, 2022

Haven't tested but looks good with the exception of that openfec flag.

@bgamari
Copy link
Contributor Author

bgamari commented Jan 2, 2022

FWIW, I am able to load the roc-sink and roc-source modules and can stream audio between them.

@bgamari
Copy link
Contributor Author

bgamari commented Jan 2, 2022

For the record, this was tested using the backport to 21.11 in https://github.com/bgamari/nixpkgs/tree/wip/rpi-pipewire-21.11 (which also upgrades pipewire to 0.3.42). Perhaps this should be merged to nixos-21.11?

@Mic92 Mic92 merged commit ff764c3 into NixOS:master Jan 4, 2022
@Mic92
Copy link
Member

Mic92 commented Jan 4, 2022

For the record, this was tested using the backport to 21.11 in https://github.com/bgamari/nixpkgs/tree/wip/rpi-pipewire-21.11 (which also upgrades pipewire to 0.3.42). Perhaps this should be merged to nixos-21.11?

No strong opinion on that but since is a non-trivial change of the package, we should gives this some weeks in the nixos-unstable channel to see if there any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants