Meson bump#153082
Closed
AndersonTorres wants to merge 8 commits intoNixOS:stagingfrom
AndersonTorres:meson-bump
Closed
Meson bump#153082AndersonTorres wants to merge 8 commits intoNixOS:stagingfrom AndersonTorres:meson-bump
AndersonTorres wants to merge 8 commits intoNixOS:stagingfrom
AndersonTorres:meson-bump
Conversation
12 tasks
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 501+
primeos
reviewed
Jan 1, 2022
Comment on lines
+1
to
+25
Member
There was a problem hiding this comment.
Not a blocker but I hate those refactorings in unrelated commits (it's a bad commit practice). We should either reformat all of Nixpkgs at once or packages individually. A commit like 3d74e57 ("wlroots 0.15: change meson attribute - Meson 0.60 is the default now") shouldn't contain such unrelated changes.
Member
Author
There was a problem hiding this comment.
Understandable.
I prefer to do such code refactorings among other things because they did not change the semantics of the code.
Anyway I have splitted the commits in order to reflect this.
Systemd fails to build with new Meson. According to Ofborg logs at https://gist.github.com/GrahamcOfBorg/d1304f0fc0ed308713303361273522a7 ``` meson.build:3:0: ERROR: Unknown options: "cryptsetup, kill-path" ```
A quick and easy rewriting.
wlroots runs whenever wayland runs. Nowadays Wayland is linux-only, however there are some projects attempting to port it to other Unices. Therefore, it is better to bind meta.platforms to Wayland.
Meson 0.60 is the default now.
Meson 0.60 is the default now.
Meson 0.60 is the default now.
Meson 0.60 is the default now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Get rid of old Meson
#144779
As I have said before, the plan is:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes