Closed
Conversation
70-yubikey.rules depends on ConsoleKit which is not used by NixOS anymore and has been superseeded by systemd The ./configure flag also supports a --with-udevrulesdir flag but it fails the detection and selects the wrong .rules file.
It was shipping two competing rules. Only use the modern-one.
|
By analyzing the blame information on this pull request, we identified @the-kenny, @wkennington and @fpletz to be potential reviewers |
Contributor
|
Merging this in a moment after fixing the typo ( |
Contributor
|
Merged with a small bugfix (4ab72c5) |
Member
Author
|
Thanks kenny |
This was referenced Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Fixing some udev rules