python3Packages.dm-tree: refactor to build from sources#152971
Merged
samuela merged 2 commits intoNixOS:masterfrom Jan 1, 2022
Merged
python3Packages.dm-tree: refactor to build from sources#152971samuela merged 2 commits intoNixOS:masterfrom
samuela merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
jonringer
reviewed
Dec 31, 2021
Comment on lines
28
to
31
| -set(ABSEIL_VER 20210324.2) | ||
| -include(ExternalProject) | ||
| -ExternalProject_Add(abseil-cpp | ||
| - GIT_REPOSITORY https://github.com/abseil/abseil-cpp.git |
Contributor
There was a problem hiding this comment.
Use of vendored source is an anti-pattern. Would be nice if upstream supported find_package
Contributor
There was a problem hiding this comment.
not a blocker for this PR though
Contributor
Author
There was a problem hiding this comment.
Rebased to the most recent commit and changed the patch to hopefully be submittable to the upstream (= falling back to vendored deps if find_package fails), will try to open PR with them but keeping the patch here for now as I want to decouple upstream PR from this one.
samuela
reviewed
Dec 31, 2021
Member
samuela
left a comment
samuela
left a comment
There was a problem hiding this comment.
LGTM after comments are addressed
samuela
approved these changes
Dec 31, 2021
Member
samuela
left a comment
samuela
left a comment
There was a problem hiding this comment.
LGTM I'll squash and merge tomorrow unless anyone objects.
simeoncarstens
added a commit
to simeoncarstens/nixpkgs
that referenced
this pull request
Jan 19, 2022
tensorflow-probability 0.8 was broken and marked as such (in NixOS#108977) because of a dependency on dm-tree, which seems not to have been available. Since dm-tree is now available in nixpkgs (NixOS#152971), tensorflow-probability is easy to fix and to upgrade.
13 tasks
simeoncarstens
added a commit
to simeoncarstens/nixpkgs
that referenced
this pull request
Jan 26, 2022
tensorflow-probability 0.8 was broken and marked as such (in NixOS#108977) because of a dependency on dm-tree, which seems not to have been available. Since dm-tree is now available in nixpkgs (NixOS#152971), tensorflow-probability is easy to fix and to upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Part of "extra JAX libraries / frameworks" implementation, see the discussion in #152754
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes