Skip to content

python3Packages.deepdish: init at 0.3.7#152970

Merged
jonringer merged 1 commit intoNixOS:masterfrom
ndl:submit/deepdish
Dec 31, 2021
Merged

python3Packages.deepdish: init at 0.3.7#152970
jonringer merged 1 commit intoNixOS:masterfrom
ndl:submit/deepdish

Conversation

@ndl
Copy link
Contributor

@ndl ndl commented Dec 31, 2021

Motivation for this change

Part of "extra JAX libraries / frameworks" implementation, see the discussion in #152754

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ndl ndl requested review from FRidh and jonringer as code owners December 31, 2021 17:04
@ndl ndl requested a review from samuela December 31, 2021 17:04
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 31, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 31, 2021
jonringer
jonringer reviewed Dec 31, 2021
View reviewed changes
pkgs/development/python-modules/deepdish/default.nix
# pandas
# ];

# The tests are broken: `ModuleNotFoundError: No module named 'deepdish.six.conf'`
Copy link
Contributor

@jonringer jonringer Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create an upstream issue

jonringer
jonringer approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 152970 run on x86_64-linux 1

2 packages built:
  • python38Packages.deepdish
  • python39Packages.deepdish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@samuela samuela Awaiting requested review from samuela

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndl @jonringer