Skip to content

[staging] python3Packages.tappy: 3.0 -> 3.1#152942

Closed
SFrijters wants to merge 1 commit intoNixOS:stagingfrom
SFrijters:tappy-3.1
Closed

[staging] python3Packages.tappy: 3.0 -> 3.1#152942
SFrijters wants to merge 1 commit intoNixOS:stagingfrom
SFrijters:tappy-3.1

Conversation

@SFrijters
Copy link
Member

@SFrijters SFrijters commented Dec 31, 2021 •
edited
Loading

Motivation for this change

Upstream update.

Things done

When I added this package it was as a dependency for one particular package, but it seems to have made its way into another package waaaay down the dependency tree, so now there's about a 4.5k packages worth of nixpkgs-review, which I don't think I have the rebuild capacity for.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 31, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 31, 2021
@fabaff
Copy link
Member

fabaff commented Jan 4, 2022

This should go to staging.

@SFrijters SFrijters changed the base branch from master to staging January 5, 2022 16:26
@SFrijters SFrijters changed the title python3Packages.tappy: 3.0 -> 3.1 [staging] python3Packages.tappy: 3.0 -> 3.1 Jan 5, 2022
@SFrijters
Copy link
Member Author

SFrijters commented Jan 5, 2022

Retargeted to staging.

@SFrijters
Copy link
Member Author

SFrijters commented Jan 13, 2022 •
edited
Loading

This will probably be a lot easier to test/merge when #154096 is merged since it removes this package as a dependency from a low-level package.

@SFrijters
Copy link
Member Author

SFrijters commented Jan 25, 2022

Already merged into staging via 645ddf9

@SFrijters SFrijters closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SFrijters @fabaff