Skip to content

nixos/logrotate: enable multiple paths per entry #152223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aanderse merged 2 commits into from
Jan 3, 2022
Merged

nixos/logrotate: enable multiple paths per entry #152223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2fd94a
nixos/logrotate: enable multiple paths per entry
ju1m Dec 26, 2021
f7ff512
nixos/logrotate: rotate login/logout logs by default
ju1m Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 35 additions & 7 deletions nixos/modules/services/logging/logrotate.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ with lib;

let
cfg = config.services.logrotate;
inherit (config.users) groups;

pathOpts = {
pathOpts = { name, ... }: {
options = {
enable = mkOption {
type = types.bool;
Expand All @@ -16,10 +17,19 @@ let
'';
};

path = mkOption {
name = mkOption {
type = types.str;
internal = true;
};

path = mkOption {
type = with types; either str (listOf str);
default = name;
defaultText = "attribute name";
description = ''
The path to log files to be rotated.
Spaces are allowed and normal shell quoting rules apply,
with ', ", and \ characters supported.
'';
};

Expand Down Expand Up @@ -74,6 +84,7 @@ let
};
};

config.name = name;
config.extraConfig = ''
missingok
notifempty
Expand All @@ -82,15 +93,15 @@ let

mkConf = pathOpts: ''
# generated by NixOS using the `services.logrotate.paths.${pathOpts.name}` attribute set
"${pathOpts.path}" {
${concatMapStringsSep " " (path: ''"${path}"'') (toList pathOpts.path)} {
${optionalString (pathOpts.user != null || pathOpts.group != null) "su ${pathOpts.user} ${pathOpts.group}"}
${pathOpts.frequency}
rotate ${toString pathOpts.keep}
${pathOpts.extraConfig}
}
'';

paths = sortProperties (mapAttrsToList (name: pathOpts: pathOpts // { name = name; }) (filterAttrs (_: pathOpts: pathOpts.enable) cfg.paths));
paths = sortProperties (attrValues (filterAttrs (_: pathOpts: pathOpts.enable) cfg.paths));
configFile = pkgs.writeText "logrotate.conf" (concatStringsSep "\n" ((map mkConf paths) ++ [ cfg.extraConfig ]));

in
Expand Down Expand Up @@ -152,17 +163,34 @@ in
}
) cfg.paths;

services.logrotate = {
paths = {
"/var/log/btmp" = {
frequency = mkDefault "monthly";
keep = mkDefault 1;
extraConfig = ''
create 0660 root ${groups.utmp.name}
'';
};
"/var/log/wtmp" = {
frequency = mkDefault "monthly";
keep = mkDefault 1;
extraConfig = ''
create 0664 root ${groups.utmp.name}
'';
};
};
};

systemd.services.logrotate = {
description = "Logrotate Service";
wantedBy = [ "multi-user.target" ];
startAt = "hourly";
script = ''
exec ${pkgs.logrotate}/sbin/logrotate ${configFile}
'';

serviceConfig = {
Restart = "no";
User = "root";
ExecStart = "${pkgs.logrotate}/sbin/logrotate ${configFile}";
};
};
};
Expand Down