Skip to content

libxcvt: init at 0.1.1#151862

Merged
vcunat merged 1 commit intoNixOS:masterfrom
drperceptron:libxcvt
Jan 16, 2022
Merged

libxcvt: init at 0.1.1#151862
vcunat merged 1 commit intoNixOS:masterfrom
drperceptron:libxcvt

Conversation

@drperceptron
Copy link
Contributor

@drperceptron drperceptron commented Dec 23, 2021

Motivation for this change

Partial contribution to #150133

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 23, 2021
@OPNA2608
Copy link
Contributor

OPNA2608 commented Dec 23, 2021

I think this belongs into pkgs/servers/x11/xorg/default.nix instead like all the other xorg packages.

  • In pkgs/servers/x11/xorg/tarballs.list, add mirror://xorg/individual/lib/libxcvt-0.1.1.tar.xz.
  • In pkgs/servers/x11/xorg/generate-expr-from-tarballs.pl:
    • At the start of the file, add meson and ninja to the list in my @missingPCs.
    • Search for print "REQUIRES and add push @nativeRequires, "meson", "ninja" if $pkg =~ /libxcvt/; to the block above it.
  • Then run ./generate-expr-from-tarballs.pl tarballs.list to regenerate the list of xorg packages & commit all the changes.

@TredwellGit
Copy link
Member

#153994

@vcunat vcunat merged commit 5bca761 into NixOS:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants