Conversation
|
LOL no way you beat me to it 😄 |
There are some breaking changes in new Zig. |
|
Yay I'm the maintainer of the only future-proof Zig package! Jokes aside let me link zigtools/zls#438 and riverwm/river#489. |
|
And zls now builds on 0.9.0. Do we need to wait until river is updated? |
|
river 0.1.2 with zig 0.9 support has been released. I'm not sure how backward compatible 0.9 is but I suppose it might be easier to upgrade all of them in the same PR. |
|
But river 0.1.2 requires wlroots 0.15.0 which is still in staging. Maybe there should be two versions of zig in nixpkgs for now. |
|
Here we go, now there are two zigs and this PR can be safely merged. |
My absolute favorite thing about NixOS, hands down. (Not being sarcastic) |
| river = callPackage ../applications/window-managers/river { | ||
| zig = zig_0_8_1; | ||
| }; |
There was a problem hiding this comment.
| river = callPackage ../applications/window-managers/river { | |
| zig = zig_0_8_1; | |
| }; | |
| river = callPackage ../applications/window-managers/river { }; |
river 0.1.2 calls for zig 0.9.0 now, otherwise LGTM
There was a problem hiding this comment.
Isn't river 0.1.2 still in staging? And this PR is in master.
There was a problem hiding this comment.
I decided not to target staging, and wait for the wlroots update to hit master.
There was a problem hiding this comment.
Then it should be zig = zig_0_8_1;, so this PR could be merged before the wlroots update hits the master.
|
GH-151234 with wlroots 0.15.0 has been merged, I think Zig 0.8.1 can be dropped now. |
|
It's still 0.14.1 in master. |
|
Right, sorry, my mistake. |
|
I wish you all a happy new year! |
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes