Skip to content

calamares: fix module functionality#151508

Closed
vlinkz wants to merge 2 commits intoNixOS:masterfrom
vlinkz:master
Closed

calamares: fix module functionality#151508
vlinkz wants to merge 2 commits intoNixOS:masterfrom
vlinkz:master

Conversation

@vlinkz
Copy link
Member

@vlinkz vlinkz commented Dec 21, 2021

Motivation for this change

The calamares locale module segfaults and crashes calamares when loaded. When the keyboard module is used, no options are available. Both of these modules were broken due to hardcoded paths pointing to the wrong files. Also, the password quality checking functionality in the users module was missing.

Things done

Changed hardcoded paths to fix the issues in the locale and keyboard modules. Also added libpwquality dependency to enable password quality checking in the users module.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Some modules had incorrect file paths, causing crashes and segfaults. Also added libpwquality to enable password quality checking in the users module.
@ofborg ofborg bot requested a review from manveru December 21, 2021 05:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 21, 2021
@vlinkz
Copy link
Member Author

vlinkz commented Jan 2, 2022

I removed changes that were unnecessary for proper execution of the program. I also added a fix for launching from the desktop.

@vlinkz vlinkz requested a review from bobby285271 January 5, 2022 01:21
@vlinkz vlinkz closed this Feb 25, 2022
@vlinkz
Copy link
Member Author

vlinkz commented Feb 25, 2022

Closed in favor of #161788

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants