calamares: fix module functionality#151508
Closed
vlinkz wants to merge 2 commits intoNixOS:masterfrom
vlinkz:master
Closed
calamares: fix module functionality#151508vlinkz wants to merge 2 commits intoNixOS:masterfrom vlinkz:master
vlinkz wants to merge 2 commits intoNixOS:masterfrom
vlinkz:master
Conversation
Some modules had incorrect file paths, causing crashes and segfaults. Also added libpwquality to enable password quality checking in the users module.
bobby285271
reviewed
Jan 1, 2022
bobby285271
reviewed
Jan 1, 2022
Member
Author
|
I removed changes that were unnecessary for proper execution of the program. I also added a fix for launching from the desktop. |
Member
Author
|
Closed in favor of #161788 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The calamares locale module segfaults and crashes calamares when loaded. When the keyboard module is used, no options are available. Both of these modules were broken due to hardcoded paths pointing to the wrong files. Also, the password quality checking functionality in the users module was missing.
Things done
Changed hardcoded paths to fix the issues in the locale and keyboard modules. Also added libpwquality dependency to enable password quality checking in the users module.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes