Merged
Conversation
|
By analyzing the blame information on this pull request, we identified @offlinehacker, @jgillich and @vcunat to be potential reviewers |
joachifm
added
the
0.kind: enhancement
Also remove redundant buildInputs
joachifm
force-pushed
the
torbrowser-enhancements
branch
from
2c02c43 to
ad6d311
Compare
This brings the wrapper closer to the upstream wrapper. Briefly, - exec to prevent the shell from hanging around - do not connect to session manager - set WM_CLASS to "Tor Browser" - use fonts.conf from the torbrowser bundle
joachifm
force-pushed
the
torbrowser-enhancements
branch
from
ad6d311 to
c3f5496
Compare
This was referenced Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Note that I intend to squash the wrapper enhancement before merging.