Skip to content

Conversation

@thefloweringash
Copy link
Member

Motivation for this change

When trying to use help2man in a package, I see the following error:

help2man -i ssh-agent-filter.help2man -o ssh-agent-filter.1 -N -L C.UTF-8 ./ssh-agent-filter
help2man: no locale support (Locale::gettext required)

The configure script for help2man uses gettext if available, so if gettext is not available it will silently build without nls support. If I pass --enable-nls to configure:

❯ nix-build -E 'let pkgs = import ./. {}; in pkgs.help2man.overrideAttrs (_:{ configureFlags = [ "--enable-nls" ]; })'
[...]
checking for library containing bindtextdomain... no
configure: error: bindtextdomain() required

I think this was caused by e73d334 in #142602. cc @Artturin

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Dec 14, 2021
@ofborg ofborg bot requested a review from pSub December 14, 2021 06:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 14, 2021
@Artturin
Copy link
Member

@ofborg build help2man

2 similar comments
@Artturin

This comment was marked as duplicate.

@Artturin

This comment was marked as duplicate.

@Artturin Artturin merged commit 7ada728 into NixOS:staging Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants