Revert "nixos/lib/make-options-doc: generate options.xml from options…#150623
Closed
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
Closed
Revert "nixos/lib/make-options-doc: generate options.xml from options…#150623sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
Conversation
….json" This reverts commit 027f7e1. Reason for revert: `${pkgs.nix}/bin/nix-instantiate --store dummy://` doesn't work if `pkgs.nix == pkgs.nix_2_3` which makes it impossible to build a NixOS system configuration with Nix 2.3 at the moment. Keeping Nix 2.3 compatibility on master is still important.
github-actions
bot
added
the
6.topic: nixos
Member
Author
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
Contributor
|
can be fixed without revert: #150631 |
Member
|
Fixed with @pennae's PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….json"
This reverts commit 027f7e1.
Reason for revert:
${pkgs.nix}/bin/nix-instantiate --store dummy://doesn't work if
pkgs.nix == pkgs.nix_2_3which makes it impossible tobuild a NixOS system configuration with Nix 2.3 at the moment. Keeping
Nix 2.3 compatibility on master is still important.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes