pulseaudio: wrong path fallout from multiple outputs

[peterhoeg]

This isn't tested admittedly, but ShouldJustWork(tm).

needs .out appended to package

[mention-bot]

By analyzing the blame information on this pull request, we identified @abbradar, @ttuegel and @edolstra to be potential reviewers

[ttuegel]

I fixed this on staging by instead changing the default value for config.hardware.pulseaudio.package so that it points to the .out output only. I leave it to the other reviewers to decide which solution they like better; there are probably arguments in favor of either.

[abbradar]

I think let's do it the way @peterhoeg proposes, but using getBin function. The reason is to save the interface -- users now have things like package = pulseaudioFull and they would have PulseAudio silently broken because of invalid output selected. getBin allows one who truly wants some output to be specified to do so: it has necessary magic so that package = myPulseaudio.foo would work as intended.

[abbradar]

Pushed as 5e2bb0b. I originally pushed this to staging, but it looks like @ttuegel's changes are already in master, so cherry-picked there.

[abbradar]

Ouch, master doesn't have getBin yet. I've reverted the patch from master for now; staging looks nearly finished building so I expect the merge will be done soon.

[peterhoeg]

@abbradar, maybe this is off-topic, but how does getBin work with packages that do not define a bin output?

[abbradar]

@peterhoeg It uses out and then pkg itself. Plus, it checks if the output has already been specified. It's easier to see in the code:

    if pkg.outputUnspecified or false
      then pkg.${output} or pkg.out or pkg
      else pkg;