Skip to content

Comments

open-eid#15016

Merged
jagajaga merged 8 commits intoNixOS:masterfrom
jagajaga:eid
Apr 28, 2016
Merged

open-eid#15016
jagajaga merged 8 commits intoNixOS:masterfrom
jagajaga:eid

Conversation

@jagajaga
Copy link
Member

@jagajaga jagajaga commented Apr 26, 2016

WIP
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@aszlig @bluescreen303 (top guys from google-talk plugin) please help me with firefox plugin. It doesn't seem to work :/

@jagajaga jagajaga self-assigned this Apr 26, 2016
@jagajaga jagajaga added 0.kind: enhancement Add something new or improve an existing system. 9.needs: reporter feedback This issue needs the person who filed it to respond labels Apr 26, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vcunat, @edolstra and @ttuegel to be potential reviewers

@jagajaga
Copy link
Member Author

Current problems: qdigidoc doesn't compile, see [1]; firefox plugins seems not to work, see [2].
Any help is much appreciated!

[1] open-eid/qdigidoc#9
[2] open-eid/browser-token-signing#3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: fix

@jagajaga
Copy link
Member Author

Current situation. qdigidoc compiles and works.
Firefox Plugin now sees the library but doesn't work anyway.

@jagajaga
Copy link
Member Author

Now everything works!

Please note, that you need to do in firefox:
Settings->Advanced->Certificates->Security devices->Load
and add onepin-opensc-pkcs11.so from opensc pkg.

@jagajaga
Copy link
Member Author

Going to merge in a day if no objections.

@jagajaga
Copy link
Member Author

cc @joachifm for review :)

name = "esteidfirefoxplugin-${version}";

src = fetchurl {
url = "https://installer.id.ee/media/ubuntu/pool/main/e/esteidfirefoxplugin/esteidfirefoxplugin_3.12.1.1142.orig.tar.xz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is possible to re-use version here (and elsewhere)

@joachifm
Copy link
Contributor

@jagajaga I'm afraid I know too little about this software to provide much useful feedback, but looks fairly straight-forward to me.

@jagajaga
Copy link
Member Author

@joachifm thank you.

@joachifm
Copy link
Contributor

Actually, I just realized that certs.patch is absolutely gigantic. I don̈́t suppose it's possible to fetch it from somewhere instead of checking it into the repo?

@jagajaga
Copy link
Member Author

@joachifm no, we can't fetch it from anywhere in easyway. Because it's located on private servers and downloaded at build time. We can't download during build time so that's why I've created a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 9.needs: reporter feedback This issue needs the person who filed it to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants