Closed
Conversation
KISS. Fix-points are fun but also make things less approachable. Functions in lib/fixed-point.nix had to know that they were being used in the lib/default.nix and couldn't rely on lib. If you find yourself needing to replace an existing lib function, patch entangled. For example lib/fixed-point.sh nixpkgs (this should be pretty rare). Extending is still possible with the merge (`//`) operator.
github-actions
bot
added
the
6.topic: agda
roberth
reviewed
Dec 9, 2021
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
This is a good change, but also a breaking change. Users of lib.extend should be given time to migrate their code with a deprecation message. The message should reference documentation that helps them migrate. They'll need to learn about specialArgs for example.
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
I'm against this in its current form because it breaks the original reason I added |
Member
Author
|
Thanks, with the extra context, I don't believe that this PR is worth it anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KISS. Fix-points are fun but also make things less approachable.
Functions in lib/fixed-point.nix had to know that they were being used
in the lib/default.nix and couldn't rely on lib.
If you find yourself needing to replace an existing lib function, patch
entangled. For example lib/fixed-point.sh
nixpkgs (this should be pretty rare). Extending is still possible with
the merge (
//) operator.Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes