Skip to content

nixos: force the user to set system.stateVersion #149877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zimbatm wants to merge 1 commit into from
Closed

nixos: force the user to set system.stateVersion #149877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nixos/modules/misc/version.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ in

stateVersion = mkOption {
type = types.str;
default = cfg.release;
default = throw "system.stateVersion needs to be set. Use the value of the current release.";
description = ''
Every once in a while, a new NixOS release may change
configuration defaults in a way incompatible with stateful
Expand Down
9 changes: 6 additions & 3 deletions nixos/release.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@ let
};
};
allTests =
foldAttrs recursiveUpdate {} (map allTestsForSystem supportedSystems);
foldAttrs recursiveUpdate { } (map allTestsForSystem supportedSystems);

pkgs = import ./.. { system = "x86_64-linux"; };


versionModule =
{ system.nixos.versionSuffix = versionSuffix;
{
system.nixos.versionSuffix = versionSuffix;
system.nixos.revision = nixpkgs.rev or nixpkgs.shortRev;
system.stateVersion = mkForce "21.04";
Copy link
Member

@vcunat vcunat Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21.04?

};

makeModules = module: rest: [ configuration versionModule module rest ];
Expand Down Expand Up @@ -92,9 +94,10 @@ let
buildFromConfig = module: sel: forAllSystems (system: hydraJob (sel (import ./lib/eval-config.nix {
inherit system;
modules = makeModules module
({ ... }:
({ config, ... }:
{ fileSystems."/".device = mkDefault "/dev/sda1";
boot.loader.grub.device = mkDefault "/dev/sda";
system.stateVersion = mkDefault config.system.version;
});
}).config));

Expand Down