Skip to content

[staging-next] Revert "util-linux: fix static build"#149530

Merged
veprbl merged 1 commit intoNixOS:stagingfrom
alyssais:util-linux-static
Dec 19, 2021
Merged

[staging-next] Revert "util-linux: fix static build"#149530
veprbl merged 1 commit intoNixOS:stagingfrom
alyssais:util-linux-static

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Dec 8, 2021

This reverts commit 1f0ef84. The underlying issue was fixed in 2ebeb02 ("stdenv/setup: tell libtool about library paths"), so we don't need a workaround in util-linux any more.

@SCOTT-HAMILTON, #144749 was merged two days before #147429 was opened. Since static stuff is moving quite quickly in Nixpkgs at the moment, it's worth checking whether an issue still exists on staging before submitting a fix.

@alyssais alyssais added the 6.topic: static Static builds (e.g. pkgsStatic) label Dec 8, 2021
This reverts commit 1f0ef84.  The
underlying issue was fixed in 2ebeb02 ("stdenv/setup: tell libtool
about library paths"), so we don't need a workaround in util-linux any
more.
@alyssais alyssais changed the base branch from staging to staging-next December 8, 2021 05:43
@alyssais alyssais changed the title Revert "util-linux: fix static build" [staging-next] Revert "util-linux: fix static build" Dec 8, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 8, 2021
@alyssais
Copy link
Member Author

alyssais commented Dec 8, 2021

@ofborg build util-linux.override{systemd=null;}

@veprbl veprbl changed the base branch from staging-next to staging December 19, 2021 17:23
@veprbl veprbl merged commit 984f2b0 into NixOS:staging Dec 19, 2021
@alyssais alyssais deleted the util-linux-static branch June 9, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: static Static builds (e.g. pkgsStatic) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants