postgresql_{11,12,13,14}: build with support for JIT compilation#149517
Closed
ivan wants to merge 2 commits intoNixOS:masterfrom
Closed
postgresql_{11,12,13,14}: build with support for JIT compilation#149517ivan wants to merge 2 commits intoNixOS:masterfrom
ivan wants to merge 2 commits intoNixOS:masterfrom
Conversation
https://www.postgresql.org/docs/current/jit-reason.html This commit is largely a copy of dasJ's work in NixOS#124804 (comment) and andir's https://github.com/NixOS/nixpkgs/pull/124804/files
github-actions
bot
added
the
6.topic: nixos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a WIP PR for testing PostgreSQL with support for the LLVM-based JIT.
This is based almost entirely on @andir and @dasJ's work in #124804. My only real contribution here is to fix the build of
periodsandpostgiswhen postgres is built with clang.I tested only
postgresql_14(14.1) with extensionsperiodsandpostgison NixOS 21.11, and did not test other versions, macOS, or other extensions.I am unable to finish this PR right now, and I also didn't find the JIT very useful, as it caused a GIN
CREATE INDEXon an expression to use 100GB of RAM and crash the PostgreSQL server. There are similar reports of the JIT causing issues on the web and on the People, Postgres, Data Discord.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes