doc/manual,CONTRIBUTING.md: add treewide change syntax#148996
Closed
ckiee wants to merge 2 commits intoNixOS:masterfrom
Closed
doc/manual,CONTRIBUTING.md: add treewide change syntax#148996ckiee wants to merge 2 commits intoNixOS:masterfrom
ckiee wants to merge 2 commits intoNixOS:masterfrom
Conversation
Member
|
On one hand, I like it. On the other I am not sure if it is worth it to increase the complexity of the contributing document for such a niche use case. |
Member
Author
|
Looking back at this I see your point. It is annoying to read now that enough time has passed for me to forget what it said before :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#147441 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes