Skip to content

doc/manual,CONTRIBUTING.md: add treewide change syntax#148996

Closed
ckiee wants to merge 2 commits intoNixOS:masterfrom
ckiee:treewide-commits
Closed

doc/manual,CONTRIBUTING.md: add treewide change syntax#148996
ckiee wants to merge 2 commits intoNixOS:masterfrom
ckiee:treewide-commits

Conversation

@ckiee
Copy link
Member

@ckiee ckiee commented Dec 6, 2021

Motivation for this change

#147441 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Dec 6, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 6, 2021
@jtojnar
Copy link
Member

jtojnar commented Dec 6, 2021

On one hand, I like it. On the other I am not sure if it is worth it to increase the complexity of the contributing document for such a niche use case.

@ckiee
Copy link
Member Author

ckiee commented Feb 9, 2022

Looking back at this I see your point. It is annoying to read now that enough time has passed for me to forget what it said before :P

@ckiee ckiee closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants