Closed
Conversation
php nixpkgs: PHP: fpm support (including patches for systemd socket activation) nixos systemd unit implementation keep old PHP-5.2 working even though its horrible outdated. make PHP know about /var/setuid-wrappers/sendmail (path is configurable) keep everything in one file, because most code is the same, eg the code to build extensions (apc, xdebug, ..) Well - yes - there have been quite a lot of changes in nixpkgs master. I tried to keep my branch up to date. nixos: provide php-fpm module which figures out how many php-fpm daemoens to use automatically. Its still your task to to configure apache/ nginx. You do so by using a function returning the socket path based on your configuration. nixos/modules/services/misc/phpfpm.nix contains a usage example. Enabling xdebug is very easy now. Till this gets merged you can follow the topic branch experimental/php at github.com/MarcWeber/nixpkgs. Signed-off-by: Marc Weber <marco-oweber@gmx.de>
Member
There was a problem hiding this comment.
this should be one of stdenv.lib.licenses not string if possible
Member
|
-1 This patch includes massive and seemingly unrelated changes to PHP! I don't like this. |
Contributor
Author
|
@peti : Yes, as stated in the initial PR, it depends on MarcWeber's pull request #487 @garbas : http://www.php.net/license/ if there is a better way to express that, I'll do it. |
Closed
Member
|
@tomberek #487 has been closed, as @MarcWeber doesn't want to bring it in line with the current conventions in nixpkgs. Please feel free to reopen this if you're willing to remove that dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding OPcache to nixpkgs. Works well with and integrated with e08c7d0. Did not test without that commit, but it should work. I can cherry-pick this off, but I also want to encourage #487