Skip to content

emacsMacport: fix aarch64-darwin#147603

Closed
kloenk wants to merge 1 commit intoNixOS:masterfrom
kloenk:emac-mac
Closed

emacsMacport: fix aarch64-darwin#147603
kloenk wants to merge 1 commit intoNixOS:masterfrom
kloenk:emac-mac

Conversation

@kloenk
Copy link
Member

@kloenk kloenk commented Nov 27, 2021

Motivation for this change

Make emacsMacport compile under aarch64-darwin

Things done

emacsMacport does not currently open as gui. That's not yet fixed

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kloenk kloenk requested a review from adisbladis as a code owner November 27, 2021 15:43
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 27, 2021
@github-actions github-actions bot added the 6.topic: emacs Text editor label Nov 27, 2021
@kloenk
Copy link
Member Author

kloenk commented Nov 27, 2021

The missing gui seems to be related to llvm, which I had to bump, to pass eval on aarch64.

@ofborg ofborg bot requested review from jwiegley and matthewbauer November 27, 2021 15:58
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 27, 2021
@veprbl veprbl changed the title emacMacport: fix aarch64-darwin emacsMacport: fix aarch64-darwin Nov 28, 2021
SuperSandro2000
SuperSandro2000 reviewed Nov 30, 2021
View reviewed changes
pkgs/applications/editors/emacs/macport.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigtool is executed on the build machine, right? Then it needs to go to nativeBuildInputs.

Copy link
Member

@siraben siraben Feb 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kloenk please move this into nativeBuildInputs.

pkgs/applications/editors/emacs/macport.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that left from debugging? I would prefer not spamming the build log.

pkgs/top-level/all-packages.nix Outdated
Comment on lines 24796 to 24797
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those really not available on other platforms?

pkgs/applications/editors/emacs/macport.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could apply this uncondtional.

@kloenk kloenk marked this pull request as draft January 12, 2022 10:15
@siraben
Copy link
Member

siraben commented Feb 6, 2022

Result of nixpkgs-review pr 147603 run on aarch64-darwin 1

1 package built:
  • emacsMacport

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 12, 2022
@isker
Copy link
Contributor

isker commented Oct 19, 2022 •
edited
Loading

I believe this is obsoleted by !155360 and can be closed.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 19, 2022
@adisbladis
Copy link
Member

adisbladis commented Oct 19, 2022

I believe this is obsoleted by !155360 and can be closed.

Yes, let's close this.

@adisbladis adisbladis closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@siraben siraben siraben left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

@jwiegley jwiegley Awaiting requested review from jwiegley

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: emacs Text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kloenk @siraben @isker @adisbladis @SuperSandro2000