Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8-polyfill: fix build #147332

Closed
wants to merge 1 commit into from
Closed

flake8-polyfill: fix build #147332

wants to merge 1 commit into from

Conversation

arkivm
Copy link
Contributor

@arkivm arkivm commented Nov 25, 2021

Motivation for this change

ZHF: #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from eadwu November 25, 2021 05:59
@arkivm arkivm force-pushed the fix-flake8-polyfill branch from 44057c7 to ae939cb Compare November 25, 2021 08:53
@AleXoundOS
Copy link
Contributor

AleXoundOS commented Nov 25, 2021 •
edited
Loading

@arkivm, why not switch to https://github.com/pycqa/flake8-polyfill altogether? Currently specified homepage states:

This has migrated to GitHub.com/pycqa/flake8-polyfill

Fresh version builds (AleXoundOS@42944c2) fine and does not require patching.

@AleXoundOS
Copy link
Contributor

AleXoundOS commented Nov 25, 2021 •
edited
Loading

Currently, fetchPypi is used which doesn't fetch from upstream (or does?). So we apply upstream patch to downstream pypi source (or do I misunderstand something?). Maybe switch to upstream github source?

@arkivm
Copy link
Contributor Author

arkivm commented Nov 25, 2021

Currently, fetchPypi is used which doesn't fetch from upstream (or does?).

It fetches from pypi.

Fresh version builds (AleXoundOS@42944c2) fine and does not require patching.

We could switch to github sources. but the problem isn't going away as upstream master still depends on this version check.

@arkivm arkivm force-pushed the fix-flake8-polyfill branch from ae939cb to 3fee224 Compare November 25, 2021 23:58
@risicle risicle mentioned this pull request Dec 3, 2021
Closed
@thiagokokada
Copy link
Contributor

I think someone already fixed this in master: #147531

@Mic92 Mic92 mentioned this pull request Dec 3, 2021
Merged
13 tasks
@arkivm arkivm closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arkivm @AleXoundOS @thiagokokada @SuperSandro2000 @jonringer @risicle