pkgsStatic.libselinux: fix build#147183
Merged
alyssais merged 1 commit intoNixOS:stagingfrom Nov 25, 2021
Merged
Conversation
Contributor
|
LGTM, my patch wasn't meant to be applied upstream so definitly would prefer yours. |
Member
Author
|
@ofborg eval |
Member
Author
|
@ofborg build pkgsStatic.libselinux libselinux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@SCOTT-HAMILTON I figured it's time to start posting some of the static work I've been doing in the last few months, to avoid any more duplication of effort. There are a few areas where our work has overlapped, but it looks like our end goals are very different (I've basically given up for GUI stuff), so hopefully there shouldn't be too many of these things where we've both come up with ways of doing the same thing. This is similar to your approach in #136107, except that it uses a patch that is suitable for upstream (and will hopefully be accepted soon), and the patch works for non-static builds too (it just provides a knob that allows shared libraries to be disabled). I think this is better because it means we're not building from slightly different sources when doing static builds (which hopefully means the patch won't stop applying next time selinux is updated if whoever does it doesn't test static builds), and if my patch is accepted upstream, we won't need to keep this patch around forever. I'd really appreciate your review.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes