Skip to content

mariadb-connector-c: fix static build#147166

Merged
veprbl merged 2 commits intoNixOS:masterfrom
SCOTT-HAMILTON:mariadb-connector-c
Nov 25, 2021
Merged

mariadb-connector-c: fix static build#147166
veprbl merged 2 commits intoNixOS:masterfrom
SCOTT-HAMILTON:mariadb-connector-c

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Part of a bigger project to build Qt 5 statically #136107.

Things done

Fixed the build of pkgsStatic mariadb-connector-c_3_1 and mariadb-connector-c_3_2.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin November 23, 2021 18:31
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 23, 2021
@veprbl veprbl added the 6.topic: static Static builds (e.g. pkgsStatic) label Nov 23, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 23, 2021
@veprbl
Copy link
Member

veprbl commented Nov 24, 2021

@GrahamcOfBorg build pkgsStatic.mariadb-connector-c

@veprbl veprbl requested a review from alyssais November 24, 2021 04:12
@alyssais
Copy link
Member

Looks fine to me, but I don't know anything about mariadb, so I won't merge for a little bit to give people who do a chance to way in and let us know if there are any pitfalls we might need to know about here.

@veprbl veprbl merged commit b47648f into NixOS:master Nov 25, 2021
mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: static Static builds (e.g. pkgsStatic) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants