ghcHEAD: fix mingw build#146959
Merged
Ericson2314 merged 1 commit intoNixOS:haskell-updatesfrom Nov 22, 2021
Merged
Conversation
alexfmpe
requested review from
cdepillabout,
expipiplus1,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
alexfmpe
commented
Nov 22, 2021
| libDeps = platform: lib.optional enableTerminfo ncurses | ||
| ++ [libffi] | ||
| libDeps = platform: | ||
| [libffi ncurses] |
Member
Author
There was a problem hiding this comment.
Seems to also be needed in windows now? https://hydra.nixos.org/build/158847644/nixlog/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Continuation of #132199 work now that https://gitlab.haskell.org/ghc/ghc/-/issues/20657 is fixed in HEAD.
I'm tempted to add these changes to ghc9.0 & ghc9.2 given they're likely to also need it (the 8.x series also has the
SplitSectionsbit), but I can't actually test that's an improvement since they fail earlier.Should the upstream fix be added as a patch in the derivations here or?
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes