Skip to content

grpc: fix build on aarch64#146720

Merged
marsam merged 1 commit intoNixOS:masterfrom
marsam:fix-grpc-aarch64
Nov 20, 2021
Merged

grpc: fix build on aarch64#146720
marsam merged 1 commit intoNixOS:masterfrom
marsam:fix-grpc-aarch64

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Nov 20, 2021 •
edited
Loading

Motivation for this change

Fixes #146580 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from LnL7 November 20, 2021 01:33
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 20, 2021
@marsam
Copy link
Contributor Author

marsam commented Nov 20, 2021

@GrahamcOfBorg build murmur bear
@GrahamcOfBorg build sysdig libtensorflow

@marsam marsam marked this pull request as ready for review November 20, 2021 02:49
@marsam marsam mentioned this pull request Nov 20, 2021
Merged
12 tasks
@marsam marsam merged commit 2e9e94a into NixOS:master Nov 20, 2021
@marsam marsam deleted the fix-grpc-aarch64 branch November 20, 2021 11:41
SuperSandro2000
SuperSandro2000 reviewed Nov 20, 2021
View reviewed changes
pkgs/development/libraries/grpc/default.nix
'';

NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang "-Wno-error=unknown-warning-option";
NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang "-Wno-error=unknown-warning-option"
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we remove Werror from the build system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marsam @SuperSandro2000