buildPythonPackage refactoring#1467
Merged
domenkozar merged 16 commits intoNixOS:masterfrom Feb 21, 2014
Merged
Conversation
Member
Author
|
I fixed all issues that I could address. I still want to update manual documention with this PR, but the rest is finished. Any further comments? |
Before we used `easy_install` command to handle installation in one shot, now this is split into two phases: - buildPhase: python setup.py build - installPhase: python setup.py install Each of those commands have the ability to pass extra parameters through buildPythonPackage parameters as `setupPyInstallFlags` and `setupPyBuildFlags`. Phases now correctly execute post/pre hooks. In configurePhase we inject setuptools dependency before distutils is imported to apply monkeypatching by setuptools that is needed for special features to apply. We don't have to reorder default phases anymore, as test phase comes after build and that works. I rewrote offineDistutils into distutils-cfg with a bit cleaner syntax and ability to specify extraCfg to the config file. Plone packages are failing and garbas said he will adopt them to the new functions. The rest of the packages I fixed and these commits shouldn't break any package (according to my testings) and they introduce 16 new jobs and fix 38 that were broken before.
…p setuptools while building)
…d and add more docs. For explanation see inline comments.
Member
Author
|
I'm going to merge this one today, once I'm sure no packages fail to build. |
domenkozar
added a commit
that referenced
this pull request
Feb 21, 2014
buildPythonPackage refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks. I've tried to split commits into separate standalone commits, but this is quite a change and it's far from perfect.
For a summary of changes see commit
Refactor buildPythonPackage to modularize building process.I'm also willing to write documentation for
buildPythonPackagefunction and other stuff that I have found out now that I've worked on it for last 3 days, once we agree that this is a step forward.There is still quite a TODO left for me to improve python infra:
fetchpypiurlthat figures out the url by package name/versionbuildPythonPackageshould have an attribute what python versions the package supports (quite tricky and also we shouldn't forget pypy)developPhase)cc @chaoflow @garbas @cillianderoiste @offlinehacker @edolstra @aszlig