Skip to content

root: Ignore default JetBrains IDEA module configuration#146607

Merged
Artturin merged 1 commit intoNixOS:masterfrom
l0b0:root/ignore-default-jetbrains-idea-module-configuration
Dec 4, 2021
Merged

root: Ignore default JetBrains IDEA module configuration#146607
Artturin merged 1 commit intoNixOS:masterfrom
l0b0:root/ignore-default-jetbrains-idea-module-configuration

Conversation

@l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 19, 2021

Motivation for this change

Avoid accidentally committing IDE configuration.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 19, 2021
@l0b0 l0b0 force-pushed the root/ignore-default-jetbrains-idea-module-configuration branch from 7457833 to 6fe93a8 Compare November 19, 2021 10:53
@github-actions github-actions bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: xfce The Xfce Desktop Environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Nov 19, 2021
@dasJ dasJ removed request for stigtsp and zakame November 19, 2021 10:54
@dasJ
Copy link
Member

dasJ commented Nov 19, 2021

Could you please open your PRs against the correct branch? This pinging seems to happen to all of your PRs.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 19, 2021
@l0b0 l0b0 mentioned this pull request Nov 19, 2021
Merged
12 tasks
@l0b0 l0b0 force-pushed the root/ignore-default-jetbrains-idea-module-configuration branch from 6fe93a8 to 168b1e0 Compare November 19, 2021 11:10
@l0b0
Copy link
Contributor Author

l0b0 commented Nov 19, 2021

Could you please open your PRs against the correct branch? This pinging seems to happen to all of your PRs.

Sorry, I keep tripping over the GitHub UI.

@l0b0 l0b0 force-pushed the root/ignore-default-jetbrains-idea-module-configuration branch from 168b1e0 to a624615 Compare November 23, 2021 07:30
@l0b0
Copy link
Contributor Author

l0b0 commented Dec 4, 2021

@Artturin Would you be OK to review this?

@Artturin
Copy link
Member

Artturin commented Dec 4, 2021

should be fine as we already have .idea/

@Artturin Artturin merged commit 77dc4ee into NixOS:master Dec 4, 2021
@l0b0 l0b0 deleted the root/ignore-default-jetbrains-idea-module-configuration branch December 5, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@l0b0 @dasJ @Artturin