Fix shellcheck SC2148 and SC1008

maintainers/scripts/check-maintainer-github-handles.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p jq parallel
+# shellcheck shell=bash
 
 # Example how to work with the `lib.maintainers` attrset.
 # Can be used to check whether all user handles are still valid.

maintainers/scripts/db-to-md.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -I nixpkgs=. -i bash -p pandoc
+# shellcheck shell=bash
 
 # This script is temporarily needed while we transition the manual to
 # CommonMark. It converts DocBook files into our CommonMark flavour.

maintainers/scripts/fetch-kde-qt.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p coreutils findutils gnused nix wget
+# shellcheck shell=bash
 
 set -efuo pipefail
 

maintainers/scripts/haskell/mark-broken.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p coreutils git -I nixpkgs=.
+# shellcheck shell=bash
 
 # This script uses the data pulled with
 # maintainers/scripts/haskell/hydra-report.hs get-report to produce a list of

maintainers/scripts/haskell/merge-and-open-pr.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p git gh -I nixpkgs=.
+# shellcheck shell=bash
 #
 # Script to merge the currently open haskell-updates PR into master, bump the
 # Stackage version and Hackage versions, and open the next haskell-updates PR.

maintainers/scripts/haskell/regenerate-hackage-packages.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p coreutils haskellPackages.cabal2nix-unstable git nix -I nixpkgs=.
+# shellcheck shell=bash
 
 # This script is used to regenerate nixpkgs' Haskell package set, using the
 # tool hackage2nix from the nixos/cabal2nix repo. hackage2nix looks at the

maintainers/scripts/haskell/regenerate-transitive-broken-packages.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p coreutils nix gnused -I nixpkgs=.
+# shellcheck shell=bash
 
 config_file=pkgs/development/haskell-modules/configuration-hackage2nix/transitive-broken.yaml
 

maintainers/scripts/haskell/update-cabal2nix-unstable.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p coreutils curl jq gnused haskellPackages.cabal2nix-unstable -I nixpkgs=.
+# shellcheck shell=bash
 
 # Updates cabal2nix-unstable to the latest master of the nixos/cabal2nix repository.
 # See regenerate-hackage-packages.sh for details on the purpose of this script.

maintainers/scripts/haskell/update-hackage.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p nix curl jq nix-prefetch-github git gnused -I nixpkgs=.
+# shellcheck shell=bash
 
 # See regenerate-hackage-packages.sh for details on the purpose of this script.
 

maintainers/scripts/haskell/update-stackage.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p nix curl jq nix-prefetch-github git gnused gnugrep -I nixpkgs=.
+# shellcheck shell=bash
 
 set -eu -o pipefail
 

maintainers/scripts/haskell/upload-nixos-package-list-to-hackage.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p nix curl gnused -I nixpkgs=.
+# shellcheck shell=bash
 
 # On Hackage every package description shows a category "Distributions" which
 # lists a "NixOS" version.

maintainers/scripts/nix-diff.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #! nix-shell -i bash -p coreutils gnugrep gnused
+# shellcheck shell=bash
 
 ################################################################################
 # nix-diff.sh                                                                  #

maintainers/scripts/patchelf-hints.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 
 usage() {
     echo "

maintainers/scripts/update-redirected-urls.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -p bash curl ripgrep jq -i bash
+# shellcheck shell=bash
 
 set -euxo pipefail
 

maintainers/scripts/update-ruby-packages

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p bundler bundix
+# shellcheck shell=bash
 
 set -euf -o pipefail
 

nixos/doc/manual/md-to-db.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -I nixpkgs=channel:nixpkgs-unstable -i bash -p pandoc
+# shellcheck shell=bash
 
 # This script is temporarily needed while we transition the manual to
 # CommonMark. It converts the .md files in the regular manual folder

nixos/lib/make-iso9660-image.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source $stdenv/setup
 
 sources_=($sources)

nixos/lib/make-system-tarball.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source $stdenv/setup
 
 sources_=($sources)

nixos/maintainers/scripts/azure-new/common.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 export group="${AZURE_RESOURCE_GROUP:-"azure"}"
 export location="${AZURE_LOCATION:-"westus2"}"
 

nixos/maintainers/scripts/gce/create-gce.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #! nix-shell -i bash -p google-cloud-sdk
+# shellcheck shell=bash
 
 set -euo pipefail
 

nixos/modules/installer/tools/nixos-build-vms/nixos-build-vms.sh

@@ -1,4 +1,5 @@
 #! @runtimeShell@ -e
+# shellcheck shell=bash
 
 # Shows the usage of this command to the user
 

nixos/modules/installer/tools/nixos-enter.sh

@@ -1,4 +1,5 @@
 #! @runtimeShell@
+# shellcheck shell=bash
 
 set -e
 

nixos/modules/installer/tools/nixos-install.sh

@@ -1,4 +1,5 @@
 #! @runtimeShell@
+# shellcheck shell=bash
 
 set -e
 shopt -s nullglob

nixos/modules/installer/tools/nixos-version.sh

@@ -1,4 +1,5 @@
 #! @runtimeShell@
+# shellcheck shell=bash
 
 case "$1" in
   -h|--help)

nixos/modules/services/networking/hylafax/faxq-wait.sh

@@ -1,4 +1,5 @@
 #! @runtimeShell@ -e
+# shellcheck shell=bash
 
 # skip this if there are no modems at all
 if ! stat -t "@spoolAreaPath@"/etc/config.* >/dev/null 2>&1

nixos/modules/services/networking/hylafax/spool.sh

@@ -1,4 +1,5 @@
 #! @runtimeShell@ -e
+# shellcheck shell=bash
 
 # The following lines create/update the HylaFAX spool directory:
 # Subdirectories/files with persistent data are kept,

nixos/modules/services/networking/ircd-hybrid/builder.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source $stdenv/setup
 
 doSub() {

nixos/modules/services/web-servers/jboss/builder.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 set -e
 
 source $stdenv/setup

nixos/modules/system/boot/stage-1-init.sh

@@ -1,4 +1,5 @@
 #! @shell@
+# shellcheck shell=bash
 
 targetRoot=/mnt-root
 console=tty1

nixos/modules/system/boot/stage-2-init.sh

@@ -1,4 +1,5 @@
 #! @shell@
+# shellcheck shell=bash
 
 systemConfig=@systemConfig@
 

nixos/modules/tasks/tty-backgrounds-combine.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source $stdenv/setup
 
 ttys=($ttys)

pkgs/applications/audio/netease-cloud-music-gtk/update-cargo-lock.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p coreutils ripgrep git cargo
+# shellcheck shell=bash
 
 # Ref: https://github.com/NixOS/nixpkgs/blob/nixos-21.05/pkgs/applications/audio/netease-music-tui/update-cargo-lock.sh
 

pkgs/applications/audio/netease-music-tui/update-cargo-lock.sh

@@ -1,5 +1,6 @@
 #!nix-shell
 #!nix-shell -i bash -p coreutils gnugrep git cargo
+# shellcheck shell=bash
 
 # This updates cargo-lock.patch for the netease-music-tui version listed in
 # default.nix.

pkgs/applications/audio/plexamp/update-plexamp.sh

@@ -1,6 +1,7 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -p yq bash curl bc ripgrep
 #! nix-shell -i bash
+# shellcheck shell=bash
 
 set -Eeuxo pipefail
 

pkgs/applications/audio/spotify/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #! nix-shell -i bash -p curl jq git gnused gnugrep
+# shellcheck shell=bash
 
 
 # executing this script without arguments will

pkgs/applications/blockchains/bisq-desktop/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl jq gnused gnupg common-updater-scripts
+# shellcheck shell=bash
 
 set -eu -o pipefail
 

pkgs/applications/blockchains/electrs/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p coreutils curl jq git gnupg common-updater-scripts
+# shellcheck shell=bash
 set -euo pipefail
 
 # Fetch latest release, GPG-verify the tag, update derivation

pkgs/applications/blockchains/nbxplorer/util/create-deps.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p dotnet-sdk_3
+# shellcheck shell=bash
 set -euo pipefail
 
 # Writes deps for dotnet package in $pkgSrc to $depsFile.

pkgs/applications/blockchains/nbxplorer/util/update-common.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p coreutils curl jq common-updater-scripts dotnet-sdk_3 git gnupg nix
+# shellcheck shell=bash
 set -euo pipefail
 
 # This script uses the following env vars:

pkgs/applications/blockchains/wasabibackend/create_deps.sh

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p dotnet-sdk_3 jq xmlstarlet curl nixpkgs-fmt
+# shellcheck shell=bash
 set -euo pipefail
 
 # Run this script to generate deps.nix

pkgs/applications/editors/emacs/elisp-packages/update-elpa

@@ -1,4 +1,5 @@
 #! /usr/bin/env nix-shell
 #! nix-shell --show-trace ./emacs2nix.nix -i bash
+# shellcheck shell=bash
 
 exec elpa-packages.sh --names $EMACS2NIX/names.nix -o elpa-generated.nix

pkgs/applications/editors/emacs/elisp-packages/update-from-overlay

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #! nix-shell -i bash -p curl nix
+# shellcheck shell=bash
 set -euxo pipefail
 
 export NIXPKGS_ALLOW_BROKEN=1

pkgs/applications/editors/emacs/elisp-packages/update-melpa

@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell --show-trace ./updater-emacs.nix -i bash
+# shellcheck shell=bash
 
 SCRIPT_DIR="$( cd "$(dirname "$0")" ; pwd -P )"
 

pkgs/applications/editors/emacs/elisp-packages/update-nongnu

@@ -1,4 +1,5 @@
 #! /usr/bin/env nix-shell
 #! nix-shell --show-trace ./emacs2nix.nix -i bash
+# shellcheck shell=bash
 
 exec nongnu-packages.sh --names $EMACS2NIX/names.nix -o nongnu-generated.nix

pkgs/applications/editors/emacs/elisp-packages/update-org

@@ -1,4 +1,5 @@
 #! /usr/bin/env nix-shell
 #! nix-shell --show-trace ./emacs2nix.nix -i bash
+# shellcheck shell=bash
 
 exec org-packages.sh --names $EMACS2NIX/names.nix -o org-generated.nix

pkgs/applications/editors/vscode/update-vscode.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl jq gnused
+# shellcheck shell=bash
 
 # Update script for the vscode versions and hashes.
 # Usually doesn't need to be called by hand,

pkgs/applications/editors/vscode/update-vscodium.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnugrep gnused gawk
+# shellcheck shell=bash
 
 # Update script for the vscode versions and hashes.
 # Usually doesn't need to be called by hand,

pkgs/applications/kde/fetch.sh

@@ -1 +1,2 @@
+# shellcheck shell=bash
 WGET_ARGS=( https://download.kde.org/stable/release-service/21.08.3/src -A '*.tar.xz' )

pkgs/applications/misc/1password-gui/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnused common-updater-scripts
+# shellcheck shell=bash
 
 version="$(curl -sL https://onepassword.s3.amazonaws.com/linux/debian/dists/edge/main/binary-amd64/Packages | sed -r -n 's/^Version: (.*)/\1/p' | head -n1)"
 update-source-version _1password-gui "$version"

pkgs/applications/misc/ArchiSteamFarm/updater.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnused jq common-updater-scripts nuget-to-nix dotnet-sdk_5
+# shellcheck shell=bash
 set -eo pipefail
 cd "$(dirname "${BASH_SOURCE[0]}")"
 

pkgs/applications/misc/adobe-reader/builder.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source $stdenv/setup
 
 echo "unpacking $src..."

pkgs/applications/misc/jekyll/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p bundix zlib
+# shellcheck shell=bash
 
 set -o errexit
 set -o nounset

pkgs/applications/misc/logseq/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl jq common-updater-scripts
+# shellcheck shell=bash
 
 version="$(curl -sL "https://api.github.com/repos/logseq/logseq/releases" | jq '.[0].tag_name' --raw-output)"
 update-source-version logseq "$version"

pkgs/applications/misc/mkgmap/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl common-updater-scripts
+# shellcheck shell=bash
 
 set -euo pipefail
 

pkgs/applications/networking/browsers/brave/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnused common-updater-scripts
+# shellcheck shell=bash
 
 version="$(curl -sL https://brave-browser-apt-release.s3.brave.com/dists/stable/main/binary-amd64/Packages | sed -r -n 's/^Version: (.*)/\1/p' | head -n1)"
 update-source-version brave "$version"

pkgs/applications/networking/browsers/vivaldi/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p libarchive curl common-updater-scripts
+# shellcheck shell=bash
 
 set -eu -o pipefail
 

pkgs/applications/networking/cluster/fluxcd/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnugrep gnused jq
+# shellcheck shell=bash
 
 set -x -eu -o pipefail
 
@@ -35,4 +36,3 @@ else
     echo "Update failed. VENDOR_SHA256 is empty."
     exit 1
 fi
-

pkgs/applications/networking/cluster/k3s/update.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnugrep gnused jq
+# shellcheck shell=bash
 
 set -x -eu -o pipefail
 

pkgs/applications/networking/cluster/linkerd/update-edge.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnugrep gnused jq
+# shellcheck shell=bash
 
 set -x -eu -o pipefail
 

pkgs/applications/networking/cluster/linkerd/update-stable.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i bash -p curl gnugrep gnused jq
+# shellcheck shell=bash
 
 set -x -eu -o pipefail