input-methods: add documentation#14602
Conversation
|
By analyzing the blame information on this pull request, we identified @edolstra, @nbp and @ryanartecona to be potential reviewers |
|
I like this. It's to the point and practical, makes sense even to a non-user. If I were to pick a nit (obligatory, right?), it'd be that EDIT: also, if you decide to update the PR, could you use a more descriptive commit subject? Like |
ericsagnes
force-pushed
the
doc/input-methods
branch
2 times, most recently
from
5a41bbf to
536d16e
Compare
nixos/doc/manual/default.nix
Outdated
There was a problem hiding this comment.
No camelCase in filenames please.
There was a problem hiding this comment.
Thanks, done in the input-method module: fix folder case commit.
ericsagnes
force-pushed
the
doc/input-methods
branch
from
536d16e to
e6ae05d
Compare
|
Thank you! |
|
|
||
| # ibus | ||
| (mkRenamedOptionModule [ "programs" "ibus" "plugins" ] [ "i18n" "inputMethod" "ibus" "engines" ]) | ||
| (mkRenamedOptionModule [ "programs" "ibus" "plugins" ] [ "i18n" "input-method" "ibus" "engines" ]) |
There was a problem hiding this comment.
Ah, I didn't notice this one; this won't work, because you didn't actually change the option name (it is independent of the folder name).
There was a problem hiding this comment.
@joachifm Should I make a new PR to fix that or can it be fixed by amending the commit?
There was a problem hiding this comment.
I pushed a hotfix, no worries
There was a problem hiding this comment.
This really is the kind of error that travis should pick up on ... oh well
5 participants
Add basic documentation for input methods.
Address #13265.