jupyter_server: Patch unicode test for Darwin #145993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test relies on creating and then reading files with unicode names to/from disk. Apple's HFS+, the default file system until recently, is unicode-normalizing with normal form D (NFD). So not all unicode file names round-trip. This patch implements one imperfect solution. ZHF: NixOS#144627
|
Nixpkgs-review: 6 packages failed to build: 10 packages built: |
|
@GrahamcOfBorg build python3Packages.jupyter_server |
|
cc @NixOS/darwin-maintainers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The test relies on creating and then reading files with unicode names
to/from disk. Apple's HFS+, the default file system until recently, is
unicode-normalizing with normal form D (NFD). So not all unicode file
names round-trip. This patch implements one imperfect solution.
ZHF: #144627
I've opened a PR to implement this upstream to see if they're ok with this solution or would prefer an alternative but I haven't received a response yet. If upstream ends up deciding on a different solution I will update this PR or open a new one.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)