Conversation
github-actions
bot
added
the
6.topic: fetch
Some literal tabs within strings should probably be spaces `\t`, but I'm not familiar enough to make that call.
I've tried to be consistent, using four or eight spaces to line up with existing code.
l0b0
force-pushed
the
fix-indentation
branch
from
92d96f6 to
57b496e
Compare
ofborg
bot
added
10.rebuild-darwin-stdenv
Member
|
ci fails. |
More risky since it affects the inside of strings.
Contributor
Author
I originally left it like that because the "indentation" is inside strings. I've added a separate commit changing that, but it's more risky. We shouldn't really use literal tabs inside Bash scripts in any case; it's really easy to mess up without noticing. |
Member
|
SPARQL doesn't seem to be indentation sensitive and it was already using mixed indentation, so this seems to be an improvement. It also isn't a critical script, so both probability and impact are low => lgtm. |
Member
|
OfBorg is ok. Staging will not make it into the release, so no need for extra concern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enforced by
editorconfig-checker, resulting in false positives).Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)