poppler-glib.pc has ${includedir}/poppler in cflags#1458
Closed
wavewave wants to merge 1 commit intoNixOS:masterfrom
Closed
poppler-glib.pc has ${includedir}/poppler in cflags#1458wavewave wants to merge 1 commit intoNixOS:masterfrom
wavewave wants to merge 1 commit intoNixOS:masterfrom
Conversation
vcunat
pushed a commit
that referenced
this pull request
Jan 5, 2014
Member
|
Looks good, pushed. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Programs/libraries that depends on poppler-glib often assumes the base directory of poppler-glib is under the base directory of poppler, and thus does not work for nixos setup.
By adding (poppler-glib base)/include/poppler in include path in cflags in pkg-config, this cures missing header problems. This was tested with haskell binding for poppler library.