libinput: 1.2.1 -> 1.2.2, propagate udev dependency#14544
Merged
fpletz merged 2 commits intoNixOS:masterfrom Apr 9, 2016
groxxda:bump/libinput
Merged
libinput: 1.2.1 -> 1.2.2, propagate udev dependency#14544fpletz merged 2 commits intoNixOS:masterfrom groxxda:bump/libinput
fpletz merged 2 commits intoNixOS:masterfrom
groxxda:bump/libinput
Conversation
|
By analyzing the blame information on this pull request, we identified @colemickens, @fpletz and @codyopel to be potential reviewers |
Member
|
What exactly does it mean to move it from a build input to a propagatedbuild input? Just for my own learning/understanding? Thanks. (Looks good to me otherwise.) |
Contributor
Author
|
Propagating it makes udev available to packages that depend on libinput. Otherwise a package that depends on libinput will also need an explicit dependency to udev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)