Skip to content

libinput: 1.2.1 -> 1.2.2, propagate udev dependency#14544

Merged
fpletz merged 2 commits intoNixOS:masterfrom
groxxda:bump/libinput
Apr 9, 2016
Merged

libinput: 1.2.1 -> 1.2.2, propagate udev dependency#14544
fpletz merged 2 commits intoNixOS:masterfrom
groxxda:bump/libinput

Conversation

@groxxda
Copy link
Contributor

@groxxda groxxda commented Apr 8, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @colemickens, @fpletz and @codyopel to be potential reviewers

@colemickens
Copy link
Member

What exactly does it mean to move it from a build input to a propagatedbuild input? Just for my own learning/understanding? Thanks. (Looks good to me otherwise.)

@groxxda
Copy link
Contributor Author

groxxda commented Apr 8, 2016

Propagating it makes udev available to packages that depend on libinput. Otherwise a package that depends on libinput will also need an explicit dependency to udev.

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Apr 9, 2016
@fpletz fpletz merged commit 870ce8f into NixOS:master Apr 9, 2016
@groxxda groxxda deleted the bump/libinput branch April 17, 2016 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants