Skip to content

Comments

minidlna: logging via journalctl, use systemd runtimedirectory, install manpages#14543

Merged
fpletz merged 3 commits intoNixOS:masterfrom
groxxda:fix/minidlna
Apr 9, 2016
Merged

minidlna: logging via journalctl, use systemd runtimedirectory, install manpages#14543
fpletz merged 3 commits intoNixOS:masterfrom
groxxda:fix/minidlna

Conversation

@groxxda
Copy link
Contributor

@groxxda groxxda commented Apr 8, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Please note, that points are not mandatory, but rather desired.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @edolstra, @ambrop72 and @rbvermaa to be potential reviewers

@groxxda groxxda changed the title Fix/minidlna minidlna: logging via journalctl, use systemd runtimedirectory, install manpages Apr 8, 2016
@fpletz fpletz added 0.kind: enhancement Add something new or improve an existing system. 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 9, 2016
@fpletz fpletz merged commit b667040 into NixOS:master Apr 9, 2016
@groxxda groxxda deleted the fix/minidlna branch April 17, 2016 22:30
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 8.has: module (update) This PR changes an existing module in `nixos/` 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants