Skip to content

fscryptctl-experimental: remove the package#144885

Merged
primeos merged 2 commits intoNixOS:masterfrom
primeos:fscryptctl-experimental
Nov 7, 2021
Merged

fscryptctl-experimental: remove the package#144885
primeos merged 2 commits intoNixOS:masterfrom
primeos:fscryptctl-experimental

Conversation

@primeos
Copy link
Member

@primeos primeos commented Nov 6, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@primeos primeos requested a review from Synthetica9 November 6, 2021 14:25
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 6, 2021
@bobby285271
Copy link
Member

👀 Shall we add an alias to pkgs/top-level/aliases.nix?

@primeos
Copy link
Member Author

primeos commented Nov 6, 2021

I don't think an alias is the best idea in this case as it could create subtle breakage. Maybe something like throw "The package fscryptctl-experimental was removed. Please switch to fscryptctl."?

It is replaced by "fscryptctl" (version 1.x is incompatible with the
pre-releases in some ways).
@primeos primeos force-pushed the fscryptctl-experimental branch from 21592b0 to 5c72b63 Compare November 7, 2021 13:45
@primeos primeos merged commit e05f811 into NixOS:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants