Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credslayer: remove failing tests, add missing runtime dependency #144655

Merged
merged 1 commit into from
Nov 4, 2021
Merged

credslayer: remove failing tests, add missing runtime dependency #144655

merged 1 commit into from
Nov 4, 2021

Conversation

legendofmiracles
Copy link
Contributor

@legendofmiracles legendofmiracles commented Nov 4, 2021 •
edited
Loading

Motivation for this change

ZHF: #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@legendofmiracles legendofmiracles force-pushed the credslayer branch 2 times, most recently from 111798a to c091de1 Compare November 4, 2021 20:45
@ofborg ofborg bot requested a review from fabaff November 4, 2021 21:11
thiagokokada
thiagokokada approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144655 run on x86_64-linux 1

1 package built:
  • credslayer

@fabaff
Copy link
Member

fabaff commented Nov 4, 2021

Result of nixpkgs-review pr 144655 run on x86_64-linux 1

1 package built:
  • credslayer

fabaff
fabaff approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 735a6f1 into NixOS:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendofmiracles @fabaff @thiagokokada