plasma-workspace: fix systemd unit detection and plasma5.runUsingSystemd#144098
Merged
peterhoeg merged 2 commits intoNixOS:masterfrom Nov 2, 2021
Merged
plasma-workspace: fix systemd unit detection and plasma5.runUsingSystemd#144098peterhoeg merged 2 commits intoNixOS:masterfrom
plasma5.runUsingSystemd#144098peterhoeg merged 2 commits intoNixOS:masterfrom
Conversation
Our units are links in systemd unit directory, which reports state `linked` or `linked-runtime`. This fixes systemdBoot config and the option `services.xserver.desktopManager.plasma5.runUsingSystemd` for plasma 5.23.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
andrevmatos
approved these changes
Nov 2, 2021
Member
andrevmatos
left a comment
andrevmatos
left a comment
There was a problem hiding this comment.
I'm running this on top of 5.23.2, and I can confirm it works: plasma services are back at their services in systemd-cgls and clock is back. Thank you. It'd be cool to have this upstreamed.
11 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Our units are links in systemd unit directory, which reports state
linkedorlinked-runtime.This fixes systemdBoot config and the option
services.xserver.desktopManager.plasma5.runUsingSystemdfor plasma 5.23.I'll consider upstream the patch later.
The breakage is introduced in 5.23.1 #139657 (comment)
This can be an alternative fix for #143272, since
plasmashellstarted by systemd will haveTZDIRcorrectly set.Things done
file))
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)