Merged
Conversation
Member
|
/participate |
Member
|
Can we come up with a test that will check this is true for future commits? |
Member
Author
|
@domenkozar Yes, my initial plan was to use the static analysis to ensure that the number issues does not grow. But we can only do that as soon as #10851 is landed, and as soon as the number of issues is low (no bad idioms remain). |
Member
|
Those changes seem both trivial (and shouldn't change hashes if I understand correctly) and affecting fast-moving target ( |
Fix conflicts: - add liquibase near llvm attributes. - Merge flashplayer-standalone-debugger expression.
domenkozar
pushed a commit
that referenced
this pull request
Sep 12, 2016
bjornfor
pushed a commit
to bjornfor/nixpkgs
that referenced
this pull request
Sep 23, 2016
…rriden packages. (cherry picked from commit 5c6bcee) There weres some conflicts, I fixed them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch aims at keeping the same hashes, but only removing aliases reported by the static analysis added in #10851 .
This branch aims at solving one of the problem which should be fixed to make the #10851 hypothesis hold, which is that all packages are defined in the first "generation" of Nixpkgs evaluation.
Thus transforming the following attribute accesses:
Into something like:
These changes are likely to bit-rot over time, thus this pull request is a meta issue / staging area for patches which are pending for review.
cc @edolstra
update: rephrase, to make statements clearer