plasma5: set default session to plasma X11 and fix sddm#143673
Merged
ttuegel merged 2 commits intoNixOS:masterfrom Nov 6, 2021
Merged
plasma5: set default session to plasma X11 and fix sddm#143673ttuegel merged 2 commits intoNixOS:masterfrom
ttuegel merged 2 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
Result of 2 packages marked as broken and skipped:
1 package failed to build:
1 package built:
Kind of strange that |
12 tasks
Member
SuperSandro2000
left a comment
There was a problem hiding this comment.
someone who knows cpp please look at the patch
Plasma wayland currently has many tiny bugs hurting user experience.
e7218f0 to
ad20e87
Compare
ttuegel
approved these changes
Nov 6, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As suggested by @ttuegel in #139657 (comment) and many others in #143272, set the default session to plasma X11 instead of wayland for now.
sddmupstream currently doesn't support system-wide default session (sddm/sddm#326), I implemented it in a patch in this PR. I'll maybe upstream it later if time permits.Note that if you logined non-default session once, it will be selected in the next time. That is, the last logined session still takes precedence over system-wide default session.
Tested in nixos vm.
cc: @abbradar @tobiasBora
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)