Skip to content

plasma5: set default session to plasma X11 and fix sddm#143673

Merged
ttuegel merged 2 commits intoNixOS:masterfrom
oxalica:fix/sddm-default-session
Nov 6, 2021
Merged

plasma5: set default session to plasma X11 and fix sddm#143673
ttuegel merged 2 commits intoNixOS:masterfrom
oxalica:fix/sddm-default-session

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Oct 29, 2021

Motivation for this change

As suggested by @ttuegel in #139657 (comment) and many others in #143272, set the default session to plasma X11 instead of wayland for now.

sddm upstream currently doesn't support system-wide default session (sddm/sddm#326), I implemented it in a patch in this PR. I'll maybe upstream it later if time permits.
Note that if you logined non-default session once, it will be selected in the next time. That is, the last logined session still takes precedence over system-wide default session.

Tested in nixos vm.

cc: @abbradar @tobiasBora

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 29, 2021
@oxalica
Copy link
Contributor Author

oxalica commented Oct 29, 2021

Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.sddm
  • libsForQt514.sddm
1 package failed to build:
  • nixos-install-tools
1 package built:
  • sddm (libsForQt5.sddm)

Kind of strange that nixos-install-tools failed. I can successfully build it with nix build -f . nixos-install-tools without problem.

@ofborg ofborg bot requested review from abbradar and ttuegel October 29, 2021 15:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 29, 2021
@FRidh FRidh added this to the 21.11 milestone Oct 30, 2021
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone who knows cpp please look at the patch

@ttuegel ttuegel merged commit a506f9c into NixOS:master Nov 6, 2021
@ttuegel
Copy link
Member

ttuegel commented Nov 6, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants