Skip to content

clutter: enable wayland compositor#142214

Closed
doronbehar wants to merge 2 commits intoNixOS:masterfrom
doronbehar:pkg/clutter
Closed

clutter: enable wayland compositor#142214
doronbehar wants to merge 2 commits intoNixOS:masterfrom
doronbehar:pkg/clutter

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 19, 2021

Motivation for this change

So I'd be able to set CLUTTER_BACKEND=wayland, per: https://wiki.archlinux.org/title/Wayland#Clutter .

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 19, 2021
@doronbehar doronbehar requested a review from jtojnar October 25, 2021 08:32
jtojnar
jtojnar reviewed Oct 25, 2021
View reviewed changes
pkgs/development/libraries/clutter/default.nix Outdated
Comment on lines 82 to 85
Copy link
Member

@jtojnar jtojnar Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misaligned (7 spaces). Though maybe we should drop this altogether – MeeGo is dead and so is Intel’s sponsorship. And the blurb does not really give any interesting info.

@jtojnar
Copy link
Member

jtojnar commented Oct 25, 2021

Are you sure this is not enabled by default? Cheese and Totem run as native Wayland apps even without this.

@doronbehar
Copy link
Contributor Author

doronbehar commented Oct 26, 2021

Are you sure this is not enabled by default? Cheese and Totem run as native Wayland apps even without this.

Interesting.. I experienced issues while I tested jami-client-gnome that I can't reproduce now.. I still think there's value in enabling the experimental Wayland compositor, but that can be debated.

@doronbehar doronbehar changed the title clutter: enable wayland backend & compositor clutter: enable wayland compositor Oct 30, 2021
@doronbehar
Copy link
Contributor Author

doronbehar commented Nov 5, 2021

The issue I encountered is https://git.jami.net/savoirfairelinux/jami-client-gnome/-/issues/1100 and it's not the fault of the clutter package. I'm closing as there's little value to this PR.

@doronbehar doronbehar closed this Nov 5, 2021
@doronbehar doronbehar deleted the pkg/clutter branch March 2, 2023 10:41
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Dec 5, 2025
@mweinelt
cpython: fix NixOSgh-142214 on 3.14.1
27dcfd3 
Fixes two regressions in dataclasses.
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 5, 2025
@mweinelt @github-actions
cpython: fix gh-142214 on 3.14.1
9bc8c09 
Fixes two regressions in dataclasses.

(cherry picked from commit 27dcfd3)
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Dec 6, 2025
@mweinelt
Revert "cpython: fix NixOSgh-142214 on 3.14.1"
7b97879 
This reverts commit 27dcfd3.

This was fixed in 3.14.2 and as such this patch application has become
obsolete.
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 6, 2025
@mweinelt @github-actions
Revert "cpython: fix gh-142214 on 3.14.1"
04d1468 
This reverts commit 27dcfd3.

This was fixed in 3.14.2 and as such this patch application has become
obsolete.

(cherry picked from commit 7b97879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronbehar @jtojnar