lib/attrsets: add filterAttrsRecursiveCond function#141934
lib/attrsets: add filterAttrsRecursiveCond function#141934r-burns wants to merge 1 commit intoNixOS:masterfrom
Conversation
|
Please add tests to |
2188f32 to
d1389b1
Compare
d1389b1 to
edf00bf
Compare
based on the mapAttrsRecursive{,Cond} functions
edf00bf to
7cc1b04
Compare
|
I took the liberty to rebase this PR on latest |
roberth
left a comment
There was a problem hiding this comment.
Please forgive my short review which is just an extension of my earlier comment. I hope it helps. Otherwise, as it's been a while, if you do not wish to work on this, you can say so and let anyone else hopefully complete it.
This PR certainly needs tests, and the documentation could be improved, just as the standard for docs is improving.
For both, I'd like to refer to #395160
|
Thanks, yeah it's been so long since I opened this that to be honest I don't remember what I was going to use it for 😅 I think the principle of this function is correct, so I'll just leave it up in case someone else finds it useful and wants to take over. Feel free to mark as draft, close, push, etc. |
based on the mapAttrsRecursive{,Cond} functions
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)