Skip to content

nixos/x11/display-managers: add session type #141760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Scriptkiddi wants to merge 1 commit into from
Closed

nixos/x11/display-managers: add session type #141760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nixos/modules/services/x11/display-managers/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ in
};

session = mkOption {
type = with types; listOf attrs;
Copy link
Contributor

@pennae pennae Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would probably be better as a listOf (submodule {...}) with all the documented attributes, or maybe even and attrsOf because having multiple session types with the same name does seem like it could cause some confusion

Copy link
Contributor Author

@Scriptkiddi Scriptkiddi Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

default = [];
example = literalExpression
''
Expand Down