Skip to content

nixos/specialisation: Add type for configuration#141733

Closed
dasJ wants to merge 1 commit intoNixOS:masterfrom
helsinki-systems:feat/type-specialisations
Closed

nixos/specialisation: Add type for configuration#141733
dasJ wants to merge 1 commit intoNixOS:masterfrom
helsinki-systems:feat/type-specialisations

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Oct 15, 2021

Motivation for this change

See #76184

@dasJ dasJ mentioned this pull request Oct 15, 2021
16 tasks
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 15, 2021
@dasJ dasJ force-pushed the feat/type-specialisations branch from d56df36 to 4994a54 Compare October 15, 2021 08:53
@dasJ dasJ changed the title nixos/specialisations: Add type for configuration nixos/specialisation: Add type for configuration Oct 15, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 15, 2021
@roberth
Copy link
Member

roberth commented Oct 29, 2021

It should be a submodule; see #143207.

@dasJ
Copy link
Member Author

dasJ commented Oct 29, 2021

But wouldn't that cause all options to be duplicated, resulting in a manual twice as long?

@dasJ
Copy link
Member Author

dasJ commented Oct 29, 2021

Ah visible = "shallow" is probably what you are going to recommend in your next comment ;)

@roberth

This comment has been minimized.

@dasJ
Copy link
Member Author

dasJ commented Oct 29, 2021

Draft until #143207 is merged

@dasJ dasJ marked this pull request as draft October 29, 2021 11:55
@dasJ
Copy link
Member Author

dasJ commented Oct 29, 2021

Nvm, #143207 actually replaces this PR

@dasJ dasJ closed this Oct 29, 2021
@dasJ dasJ deleted the feat/type-specialisations branch October 29, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants