Skip to content

nixos/unbound: add stateDir type#141730

Closed
Scriptkiddi wants to merge 1 commit intoNixOS:masterfrom
Scriptkiddi:upd/unbound
Closed

nixos/unbound: add stateDir type#141730
Scriptkiddi wants to merge 1 commit intoNixOS:masterfrom
Scriptkiddi:upd/unbound

Conversation

@Scriptkiddi
Copy link
Contributor

Motivation for this change

#76184

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi requested a review from rissson October 15, 2021 08:38
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 15, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 15, 2021
Copy link
Member

@rissson rissson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dasJ dasJ mentioned this pull request Nov 4, 2021
16 tasks
@dasJ
Copy link
Member

dasJ commented Nov 4, 2021

Wouldn't type.path be more correct here?

@Scriptkiddi
Copy link
Contributor Author

As far as I know, leads path to moving the dir into the nix store which is not desired in this case. As the dir needs to be writable.

@dasJ
Copy link
Member

dasJ commented Nov 7, 2021

It actually asks for something that can be coerced to a string and that starts with /: https://github.com/NixOS/nixpkgs/blob/master/lib/types.nix#L362

@Scriptkiddi Scriptkiddi deleted the upd/unbound branch March 16, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants