Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkgs/desktops/plasma-5/breeze-gtk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,8 @@ mkDerivation {
sed -i cmake/FindGTKEngine.cmake \
-e "s|\''${KDE_INSTALL_FULL_LIBDIR}|${getLib gtk2}/lib|"
'';
preBuild = ''
Comment on lines 12 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'';
preBuild = ''

chmod +x src/build_theme.sh
'';
cmakeFlags = [ "-DWITH_GTK3_VERSION=3.22" ];
}
2 changes: 1 addition & 1 deletion pkgs/desktops/plasma-5/fetch.sh
Original file line number Diff line number Diff line change
@@ -1 +1 @@
WGET_ARGS=( https://download.kde.org/stable/plasma/5.22.5/ -A '*.tar.xz' )
WGET_ARGS=( https://download.kde.org/stable/plasma/5.23.0/ -A '*.tar.xz' )
4 changes: 2 additions & 2 deletions pkgs/desktops/plasma-5/kscreen.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
extra-cmake-modules,
kconfig, kcmutils, kconfigwidgets, kdbusaddons, kglobalaccel, ki18n,
kwidgetsaddons, kxmlgui, libkscreen, qtdeclarative, qtgraphicaleffects, qtsensors,
kwindowsystem, kdeclarative, plasma-framework
kwindowsystem, kdeclarative, plasma-framework, wayland-scanner, wayland
}:

mkDerivation {
Expand All @@ -12,6 +12,6 @@ mkDerivation {
buildInputs = [
kconfig kcmutils kconfigwidgets kdbusaddons kglobalaccel ki18n
kwidgetsaddons kxmlgui libkscreen qtdeclarative qtgraphicaleffects qtsensors
kwindowsystem kdeclarative plasma-framework
kwindowsystem kdeclarative plasma-framework wayland-scanner wayland
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wayland-scanner goes to nativeBuildInputs IIRC you may need to add protocols to buildInputs.

];
}
6 changes: 5 additions & 1 deletion pkgs/desktops/plasma-5/kwayland-integration.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@
mkDerivation, lib,
extra-cmake-modules,
kguiaddons, kidletime, kwayland, kwindowsystem, qtbase,
wayland, wayland-protocols
}:

mkDerivation {
name = "kwayland-integration";
nativeBuildInputs = [ extra-cmake-modules ];
buildInputs = [ kguiaddons kidletime kwindowsystem kwayland qtbase ];
buildInputs = [
kguiaddons kidletime kwindowsystem kwayland qtbase
wayland wayland-protocols
];
}
12 changes: 0 additions & 12 deletions pkgs/desktops/plasma-5/kwin/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,6 @@ mkDerivation {
./0002-xwayland.patch
./0003-plugins-qpa-allow-using-nixos-wrapper.patch
./0001-NixOS-Unwrap-executable-name-for-.desktop-search.patch
# Fix build against libglvnd 1.3.4+
# Remove with release 5.22.90
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused fetchpatch from inputs.

url = "https://invent.kde.org/plasma/kwin/-/commit/839710201c389b7f4ed248cb3818e755a37ce977.patch";
sha256 = "09rldhy0sbmqdfpyjzwm20cwnmrmj0w2751vyi5xlr414g0rzyc1";
})
# Fixup previous patch for i686
# Remove with release 5.22.90
(fetchpatch {
url = "https://invent.kde.org/plasma/kwin/-/commit/38e24ecd6416a975db0989c21b70d6a4cc242f35.patch";
sha256 = "0zsjmzswcnvfd2jm1c8i9aijpbap1141mjv6y4j282bplyqlp966";
})
];
CXXFLAGS = [
''-DNIXPKGS_XWAYLAND=\"${lib.getBin xwayland}/bin/Xwayland\"''
Expand Down
8 changes: 6 additions & 2 deletions pkgs/desktops/plasma-5/libkscreen/default.nix
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
{
mkDerivation, lib, propagate,
extra-cmake-modules,
kwayland, libXrandr, qtbase, qtx11extras
kwayland, libXrandr, qtbase, qtx11extras,
plasma-wayland-protocols, wayland-scanner, wayland
}:

mkDerivation {
name = "libkscreen";
nativeBuildInputs = [ extra-cmake-modules ];
buildInputs = [ kwayland libXrandr qtx11extras ];
buildInputs = [
kwayland libXrandr qtx11extras
plasma-wayland-protocols wayland-scanner wayland
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plasma-wayland-protocols wayland-scanner wayland
plasma-wayland-protocols wayland

wayland-scanner goes to native.

];
outputs = [ "out" "dev" ];
patches = [
./libkscreen-backends-path.patch
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ diff --git a/processui/scripting.cpp b/processui/scripting.cpp
index efed8ff..841761a 100644
--- a/processui/scripting.cpp
+++ b/processui/scripting.cpp
@@ -167,7 +167,7 @@ void Scripting::loadContextMenu() {
QStringList scripts;
const QStringList dirs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "ksysguard/scripts/", QStandardPaths::LocateDirectory);
Q_FOREACH (const QString& dir, dirs) {
@@ -293,7 +293,7 @@ void Scripting::loadContextMenu() {
const QStringList dirs =
QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("ksysguard/scripts/"), QStandardPaths::LocateDirectory);
Q_FOREACH (const QString &dir, dirs) {
- QDirIterator it(dir, QStringList() << QStringLiteral("*.desktop"), QDir::NoFilter, QDirIterator::Subdirectories);
+ QDirIterator it(dir, QStringList() << QStringLiteral("*.desktop"), QDir::NoFilter, QDirIterator::Subdirectories | QDirIterator::FollowSymlinks);
while (it.hasNext()) {
Expand Down
4 changes: 2 additions & 2 deletions pkgs/desktops/plasma-5/libksysguard/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
extra-cmake-modules,
kauth, kcompletion, kconfig, kconfigwidgets, kcoreaddons, ki18n, kiconthemes,
knewstuff, kservice, kwidgetsaddons, kwindowsystem, plasma-framework,
qtbase, qtscript, qtwebengine, qtx11extras, libnl
qtbase, qtscript, qtwebengine, qtx11extras, libnl, libpcap, lm_sensors
}:

mkDerivation {
Expand All @@ -15,7 +15,7 @@ mkDerivation {
buildInputs = [
kauth kconfig ki18n kiconthemes kwindowsystem kcompletion kconfigwidgets
kcoreaddons kservice kwidgetsaddons plasma-framework qtscript qtx11extras
qtwebengine knewstuff libnl
qtwebengine knewstuff libnl libpcap lm_sensors
];
outputs = [ "bin" "dev" "out" ];
}
5 changes: 0 additions & 5 deletions pkgs/desktops/plasma-5/plasma-desktop/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ mkDerivation {
patches = [
./hwclock-path.patch
./tzdir.patch
# https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/563
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused fetchpatch from inputs.

url = "https://invent.kde.org/plasma/plasma-desktop/-/commit/8d9bf2032b8a2e5de75edf5713c42866f5b80649.patch";
sha256 = "sha256-2jqqFjBljbhf7I+fTsIvuFs3Ic662KTKRnbcSm5Jing=";
})
];
CXXFLAGS = [
''-DNIXPKGS_HWCLOCK=\"${lib.getBin util-linux}/sbin/hwclock\"''
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ diff --git a/vpn/openvpn/openvpnadvancedwidget.cpp b/vpn/openvpn/openvpnadvanced
index 2f11ba1d..310f11b4 100644
--- a/vpn/openvpn/openvpnadvancedwidget.cpp
+++ b/vpn/openvpn/openvpnadvancedwidget.cpp
@@ -75,7 +75,7 @@ OpenVpnAdvancedWidget::OpenVpnAdvancedWidget(const NetworkManager::VpnSetting::P
connect(m_ui->cmbProxyType, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, &OpenVpnAdvancedWidget::proxyTypeChanged);
@@ -80,7 +80,7 @@ OpenVpnAdvancedWidget::OpenVpnAdvancedWidget(const NetworkManager::VpnSetting::P
});

// start openVPN process and get its cipher list
- const QString openVpnBinary = QStandardPaths::findExecutable("openvpn", QStringList() << "/sbin" << "/usr/sbin");
+ const QString openVpnBinary = "@openvpn@/bin/openvpn";
- const QString openVpnBinary = QStandardPaths::findExecutable("openvpn", QStringList{"/sbin", "/usr/sbin"});
+ const QString openVpnBinary = QStandardPaths::findExecutable("openvpn", QStringList{"/sbin", "/usr/sbin", "@openvpn@/bin", "/run/current-system/sw/sbin", "/run/current-system/sw/bin"});
const QStringList ciphersArgs(QLatin1String("--show-ciphers"));
const QStringList versionArgs(QLatin1String("--version"));

6 changes: 1 addition & 5 deletions pkgs/desktops/plasma-5/plasma-nm/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,7 @@ mkDerivation {
];
patches = [
(substituteAll {
src = ./0001-mobile-broadband-provider-info-path.patch;
mobile_broadband_provider_info = mobile-broadband-provider-info;
})
(substituteAll {
src = ./0002-openvpn-binary-path.patch;
src = ./0001-openvpn-binary-path.patch;
inherit openvpn;
})
];
Expand Down
54 changes: 16 additions & 38 deletions pkgs/desktops/plasma-5/plasma-workspace/0001-startkde.patch
Original file line number Diff line number Diff line change
Expand Up @@ -14,46 +14,46 @@ diff --git a/startkde/plasma-session/startup.cpp b/startkde/plasma-session/start
index c3e77d4..88cb0e9 100644
--- a/startkde/plasma-session/startup.cpp
+++ b/startkde/plasma-session/startup.cpp
@@ -223,7 +223,7 @@ Startup::Startup(QObject *parent)
upAndRunning(QStringLiteral("ksmserver"));
@@ -203,7 +203,7 @@ Startup::Startup(QObject *parent)
const AutoStart autostart;

// Keep for KF5; remove in KF6 (KInit will be gone then)
- QProcess::execute(QStringLiteral(CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 "/start_kdeinit_wrapper"), QStringList());
+ QProcess::execute(QStringLiteral(NIXPKGS_START_KDEINIT_WRAPPER), QStringList());

KJob *phase1;
QProcessEnvironment kdedProcessEnv;
KJob *windowManagerJob = nullptr;
if (qEnvironmentVariable("XDG_SESSION_TYPE") != QLatin1String("wayland")) {
diff --git a/startkde/startplasma-waylandsession.cpp b/startkde/startplasma-waylandsession.cpp
index 4fbfe18..6ba916c 100644
--- a/startkde/startplasma-waylandsession.cpp
+++ b/startkde/startplasma-waylandsession.cpp
@@ -65,7 +65,7 @@ int main(int argc, char **argv)
waitForKonqi();
@@ -33,7 +33,7 @@ int main(int argc, char **argv)
out << "startplasma-waylandsession: Shutting down...\n";

// Keep for KF5; remove in KF6 (KInit will be gone then)
- runSync(QStringLiteral("kdeinit5_shutdown"), {});
+ runSync(QStringLiteral(NIXPKGS_KDEINIT5_SHUTDOWN), {});

cleanupX11();
out << "startplasma-waylandsession: Done.\n";

diff --git a/startkde/startplasma-x11.cpp b/startkde/startplasma-x11.cpp
index 4ddf9f8..e0e59cd 100644
--- a/startkde/startplasma-x11.cpp
+++ b/startkde/startplasma-x11.cpp
@@ -110,7 +110,7 @@ int main(int argc, char **argv)

@@ -90,7 +90,7 @@ int main(int argc, char **argv)
out << "startkde: Shutting down...\n";

// Keep for KF5; remove in KF6 (KInit will be gone then)
- runSync(QStringLiteral("kdeinit5_shutdown"), {});
+ runSync(QStringLiteral(NIXPKGS_KDEINIT5_SHUTDOWN), {});

cleanupPlasmaEnvironment();
cleanupX11();
cleanupPlasmaEnvironment(oldSystemdEnvironment);

diff --git a/startkde/startplasma.cpp b/startkde/startplasma.cpp
index 9809197..1250e3e 100644
--- a/startkde/startplasma.cpp
+++ b/startkde/startplasma.cpp
@@ -46,7 +46,7 @@ QTextStream out(stderr);
@@ -34,7 +34,7 @@ QTextStream out(stderr);
void messageBox(const QString &text)
{
out << text;
Expand All @@ -62,38 +62,16 @@ index 9809197..1250e3e 100644
}

QStringList allServices(const QLatin1String &prefix)
@@ -267,8 +267,8 @@ void setupX11()
@@ -335,7 +335,7 @@ void setupX11()
// If the user has overwritten fonts, the cursor font may be different now
// so don't move this up.

- runSync(QStringLiteral("xsetroot"), {QStringLiteral("-cursor_name"), QStringLiteral("left_ptr")});
- runSync(QStringLiteral("xprop"),
+ runSync(QStringLiteral(NIXPKGS_XSETROOT), {QStringLiteral("-cursor_name"), QStringLiteral("left_ptr")});
+ runSync(QStringLiteral(NIXPKGS_XPROP),
{QStringLiteral("-root"),
QStringLiteral("-f"),
QStringLiteral("KDE_FULL_SESSION"),
@@ -276,7 +276,7 @@ void setupX11()
QStringLiteral("-set"),
QStringLiteral("KDE_FULL_SESSION"),
QStringLiteral("true")});
- runSync(QStringLiteral("xprop"),
+ runSync(QStringLiteral(NIXPKGS_XPROP),
{QStringLiteral("-root"),
QStringLiteral("-f"),
QStringLiteral("KDE_SESSION_VERSION"),
@@ -288,8 +288,8 @@ void setupX11()

void cleanupX11()
{
- runSync(QStringLiteral("xprop"), {QStringLiteral("-root"), QStringLiteral("-remove"), QStringLiteral("KDE_FULL_SESSION")});
- runSync(QStringLiteral("xprop"), {QStringLiteral("-root"), QStringLiteral("-remove"), QStringLiteral("KDE_SESSION_VERSION")});
+ runSync(QStringLiteral(NIXPKGS_XPROP), {QStringLiteral("-root"), QStringLiteral("-remove"), QStringLiteral("KDE_FULL_SESSION")});
+ runSync(QStringLiteral(NIXPKGS_XPROP), {QStringLiteral("-root"), QStringLiteral("-remove"), QStringLiteral("KDE_SESSION_VERSION")});
}

// TODO: Check if Necessary
@@ -321,7 +321,7 @@ void setupFontDpi()
void cleanupPlasmaEnvironment(const std::optional<QStringList> &oldSystemdEnvironment)
@@ -398,7 +398,7 @@ void setupFontDpi()
// TODO port to c++?
const QByteArray input = "Xft.dpi: " + QByteArray::number(fontsCfg.readEntry("forceFontDPI", 0));
QProcess p;
Expand All @@ -102,7 +80,7 @@ index 9809197..1250e3e 100644
p.setProcessChannelMode(QProcess::ForwardedChannels);
p.write(input);
p.closeWriteChannel();
@@ -343,7 +343,7 @@ QProcess *setupKSplash()
@@ -420,7 +420,7 @@ QProcess *setupKSplash()
KConfigGroup ksplashCfg = cfg.group("KSplash");
if (ksplashCfg.readEntry("Engine", QStringLiteral("KSplashQML")) == QLatin1String("KSplashQML")) {
p = new QProcess;
Expand Down
Loading