stdenv: add sparc64 cross-compilation support #141451

piperswe · 2021-10-13T04:01:04Z

Motivation for this change

These are the trivial changes from #141448.

nix build 'github:piperswe/nixpkgs/piper/add-sparc64#pkgsCross.sparc64-linux.hello'

Things done

piperswe · 2021-10-13T04:01:42Z

@r-burns here's the trivial changes from the other pr!

r-burns · 2021-10-13T05:50:03Z

flake.nix

      lib = import ./lib;

-      systems = lib.systems.supported.hydra;
+      systems = lib.platforms.all;


this is the only part I'm not sure about, because I don't use flakes. does this just mean that you're allowed to evaluate nixpkgs on all platforms?

Hmm, well I guess I don't understand why this would ever be limited in the first place. So platforms.all seems sensible

cc @zimbatm

If a flakes person can confirm this is OK, this PR looks good to me. Or we can just punt on this, because I AFIAK this the thing the about flakes in general that's being debated right now.

I'm testing this through my personal github:piperswe/nixfiles flake on my personal Hydra instance, so I need flake support for this arch for those Hydra jobs to evaluate. I suppose I could add a non-flake jobset for these arches, but that is an added level of complexity that seems unnecessary if we can just export all platforms.

OK then we should not change this for now.

I'm 90% sure that this should not be changed. systems is like the system field of derivations (= the system/localSystem argument to nixpkgs) meaning the platform the derivation is built on. Consequently lib.systems.supported.hydra is Tier 3 and above, meaning all platforms for which a native stdenv is available.

For a jobset system can't be sparc64-linux atm anyways, as a native stdenv is not available, but rather pkgsCross needs to be used or crossSystem passed (which is not possible with flakes however as far as I know).

This change doesn't seem necessary given that sparc64-linux is only built using pkgsCross as @sternenseemann said.

The main thing you want to check is to see if nix flakes check keeps working after the change. It might also cause more/slower evaluation to have all the systems available.

r-burns · 2021-10-13T06:09:05Z

This looks great to me, I was able to build the cross bootstrap tools and cross-compile some basic packages. Once this is merged the cross-trunk job will start building cross bootstrap tools for this platform so we'll have the cross stdenv in the cache.

cc @NixOS/exotic-platform-maintainers

alyssais

Hi! It's always nice to see new platforms being added. I've reviewed the changes in lib (I'm not an expert on the other parts of Nixpkgs being changed here), and I have some changes to request.

Please maintain the alphabetical sorting in doubles.nix.
When adding new architectures, we should add them to doubles.nix for all operating systems that support that architecture. FreeBSD, OpenBSD, and NetBSD all appear to support sparc64.
Please add a filterDoubles line in doubles.nix for sparc64.
Going forward, I think platform examples contain the operating system name, because we support multiple operating systems (and hopefully increasingly so in future). So I think "sparc64-linux" would be a better name than "sparc64".

siraben · 2021-10-13T21:41:56Z

Cross-compiling GNU Hello on darwin works (pkgsCross.sparc64.hello) LGTM if @alyssais's comments are addressed.

pkgs/stdenv/linux/make-bootstrap-tools.nix

alyssais · 2021-10-14T07:37:54Z

Great work on the doubles, thanks! I'm still hoping we can get some clarity on the flakes thing — setting it to the tier3 platforms only happened recently, and I'd like to understand why that was done (which required that list to be created in the first place) instead of the much simpler solution of platforms.all.

lib/systems/doubles.nix

piperswe · 2021-10-14T17:42:12Z

Great work on the doubles, thanks! I'm still hoping we can get some clarity on the flakes thing — setting it to the tier3 platforms only happened recently, and I'd like to understand why that was done (which required that list to be created in the first place) instead of the much simpler solution of platforms.all.

Ah, I didn't notice that was a recent change. @zimbatm is there a reason why the flake doesn't export every platform?

pkgs/os-specific/linux/busybox/sandbox-shell.nix

aaronjanse · 2021-10-17T06:34:09Z

Thank you @piperswe for making this PR! I'm excited to see sparc64 support in Nixpkgs

alyssais · 2021-10-29T11:23:26Z

This is GTG apart from the flake.nix change, right? Could we just drop that for now, merge this, and have a separate PR for that change where it might be easier to get the attention of flakes experts?

sternenseemann · 2021-12-22T13:51:16Z

Bumping: Can we get this rebased and the flake change dropped?

piperswe added 2 commits October 12, 2021 23:00

stdenv: start working on adding more bootstrap tools

5bf36e5

lib/tests: add sparc64-linux to systems.nix

6957943

piperswe requested review from Ericson2314, alyssais, edolstra, infinisil, matthewbauer and nbp as code owners October 13, 2021 04:01

github-actions bot added the 6.topic: stdenv Standard environment label Oct 13, 2021

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 13, 2021

r-burns reviewed Oct 13, 2021

View reviewed changes

alyssais requested changes Oct 13, 2021

View reviewed changes

siraben approved these changes Oct 13, 2021

View reviewed changes

piperswe added 2 commits October 13, 2021 18:57

lib: flesh out doubles

0115834

lib: clean up sparc64

b032580

piperswe requested a review from alyssais October 13, 2021 23:59

piperswe added 2 commits October 13, 2021 19:34

lib: flesh out tests/systems

023ce07

busybox: don't use musl on risc-v and sparc

6171d9e

piperswe mentioned this pull request Oct 14, 2021

stdenv: add pure Linux stdenv support for powerpc64le and sparc64 #141448

Draft

12 tasks

busybox/sandbox-shell: fix eval on sparc64

b411f7e

Ericson2314 reviewed Oct 14, 2021

View reviewed changes

pkgs/stdenv/linux/make-bootstrap-tools.nix Show resolved Hide resolved

piperswe added 2 commits October 13, 2021 23:13

stdenv: re-add useMusl to busyboxMinimal

0c54199

pcre: disable JIT on SPARC

1e31925

aaronjanse reviewed Oct 14, 2021

View reviewed changes

lib/systems/doubles.nix Show resolved Hide resolved

Ericson2314 reviewed Oct 14, 2021

View reviewed changes

pkgs/os-specific/linux/busybox/sandbox-shell.nix Show resolved Hide resolved

Mindavi added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 13, 2022

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 2, 2022

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025

github-project-automation bot added this to Stdenv Jun 25, 2025

Uh oh!

stdenv: add sparc64 cross-compilation support #141451

Are you sure you want to change the base?

stdenv: add sparc64 cross-compilation support #141451

Uh oh!

Conversation

piperswe commented Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

piperswe commented Oct 13, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r-burns commented Oct 13, 2021

Uh oh!

alyssais left a comment

Choose a reason for hiding this comment

Uh oh!

siraben commented Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alyssais commented Oct 14, 2021

Uh oh!

Uh oh!

piperswe commented Oct 14, 2021

Uh oh!

Uh oh!

aaronjanse commented Oct 17, 2021

Uh oh!

alyssais commented Oct 29, 2021

Uh oh!

sternenseemann commented Dec 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

piperswe commented Oct 13, 2021 •

edited

Loading

siraben commented Oct 13, 2021 •

edited

Loading